From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Carew, Alan" <alan.carew@intel.com>
Subject: Re: [dpdk-dev] [PATCH] power: fix argument cannot be negative
Date: Mon, 16 May 2016 14:59:34 +0200 [thread overview]
Message-ID: <CA+PrjLEzn74rug9XNeWP0MSEP7Pn3EKhkVUPd_VmRq_39NRKMA@mail.gmail.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20254C2D1@IRSMSX103.ger.corp.intel.com>
2016-05-16 14:39 GMT+02:00 Mcnamara, John <john.mcnamara@intel.com>:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>> The next statement is probably a useless copy paste of the coverity
>> report.
>>
>> > In send_msg: Negative value used as argument to a function expecting a
>> > positive value (for example, size of buffer or allocation)
>
> A question on this point. Is it just that the Coverity message is useless
> in this case or in general? For other error/warning fixes we include the
> message in the commit.
Sometimes, the coverity message is accurate, sometimes it s better to reword it.
Anyway, having 2 sentences saying the same thing is disturbing.
next prev parent reply other threads:[~2016-05-16 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 14:39 Daniel Mrzyglod
2016-05-16 12:16 ` Thomas Monjalon
2016-05-16 12:39 ` Mcnamara, John
2016-05-16 12:59 ` Thomas Monjalon [this message]
2016-05-16 13:03 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+PrjLEzn74rug9XNeWP0MSEP7Pn3EKhkVUPd_VmRq_39NRKMA@mail.gmail.com \
--to=thomas.monjalon@6wind.com \
--cc=alan.carew@intel.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).