From: Jeremy Spewock <jspewock@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
wathsala.vithanage@arm.com, probb@iol.unh.edu,
paul.szczepanek@arm.com, yoan.picchi@foss.arm.com,
lylavoie@iol.unh.edu, ferruh.yigit@amd.com,
andrew.rybchenko@oktetlabs.ru, dev@dpdk.org
Subject: Re: [PATCH v6 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps
Date: Mon, 8 Jan 2024 11:37:45 -0500 [thread overview]
Message-ID: <CAAA20URyKh4PbFeR+kOtE-A7E1HkCnwfY2-x4OJ9kWimmFGrhQ@mail.gmail.com> (raw)
In-Reply-To: <CAOb5WZZTdjSr8o4f6We3AfNysibyhn_QC1mOoBhrDQ2cFpyW7A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 4602 bytes --]
On Mon, Jan 8, 2024 at 6:52 AM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:
> On Wed, Jan 3, 2024 at 11:33 PM <jspewock@iol.unh.edu> wrote:
> >
> > From: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > Changed the factory method for creating interactive apps in the SUT Node
> > so that EAL parameters would only be passed into DPDK apps since
> > non-DPDK apps wouldn't be able to process them. Also modified
> > interactive apps to allow for the ability to pass parameters into the
> > app on startup so that the applications can be started with certain
> > configuration steps passed on the command line.
> >
> > Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
> > ---
> >
> > I ended up reverting part of this back to making the argument for
> > eal_parameters allowed to be a string. This was because it was casuing
> > mypy errors where the method signatures of sut_node did not match with
> > that of node.
> >
>
> This is because the signatures don't actually match :-)
>
> The eal_parameters parameter is added on not top of what's in the base
> methods. I suggest we move eal_parameters to the end and then we don't
> need to allow str for eal_parameters.
>
> > dts/framework/remote_session/testpmd_shell.py | 2 +-
> > dts/framework/testbed_model/sut_node.py | 14 +++++++++-----
> > 2 files changed, 10 insertions(+), 6 deletions(-)
> >
> > diff --git a/dts/framework/remote_session/testpmd_shell.py
> b/dts/framework/remote_session/testpmd_shell.py
> > index f310705fac..8f40e8f40e 100644
> > --- a/dts/framework/remote_session/testpmd_shell.py
> > +++ b/dts/framework/remote_session/testpmd_shell.py
> > @@ -118,7 +118,7 @@ def _start_application(self, get_privileged_command:
> Callable[[str], str] | None
> > Also find the number of pci addresses which were allowed on the
> command line when the app
> > was started.
> > """
> > - self._app_args += " -- -i --mask-event intr_lsc"
> > + self._app_args += " -i --mask-event intr_lsc"
> > self.number_of_ports = self._app_args.count("-a ")
> > super()._start_application(get_privileged_command)
> >
> > diff --git a/dts/framework/testbed_model/sut_node.py
> b/dts/framework/testbed_model/sut_node.py
> > index c4acea38d1..4df18bc183 100644
> > --- a/dts/framework/testbed_model/sut_node.py
> > +++ b/dts/framework/testbed_model/sut_node.py
> > @@ -431,6 +431,7 @@ def create_interactive_shell(
> > timeout: float = SETTINGS.timeout,
> > privileged: bool = False,
> > eal_parameters: EalParameters | str | None = None,
> > + app_parameters: str = "",
>
> What I meant above is we should move app_parameters before
> eal_parameters and then we can remove the str type of eal_parameters.
>
Sounds good to me, I'll move these around in the next version.
>
> > ) -> InteractiveShellType:
> > """Extend the factory for interactive session handlers.
> >
> > @@ -449,20 +450,23 @@ def create_interactive_shell(
> > eal_parameters: List of EAL parameters to use to launch the
> app. If this
> > isn't provided or an empty string is passed, it will
> default to calling
> > :meth:`create_eal_parameters`.
> > + app_parameters: Additional arguments to pass into the
> application on the
> > + command-line.
> >
> > Returns:
> > An instance of the desired interactive application shell.
> > """
> > - if not eal_parameters:
> > - eal_parameters = self.create_eal_parameters()
> > -
> > - # We need to append the build directory for DPDK apps
> > + # We need to append the build directory and add EAL parameters
> for DPDK apps
> > if shell_cls.dpdk_app:
> > + if not eal_parameters:
> > + eal_parameters = self.create_eal_parameters()
> > + app_parameters = f"{eal_parameters} -- {app_parameters}"
> > +
> > shell_cls.path = self.main_session.join_remote_path(
> > self.remote_dpdk_build_dir, shell_cls.path
> > )
> >
> > - return super().create_interactive_shell(shell_cls, timeout,
> privileged, str(eal_parameters))
> > + return super().create_interactive_shell(shell_cls, timeout,
> privileged, app_parameters)
> >
> > def bind_ports_to_driver(self, for_dpdk: bool = True) -> None:
> > """Bind all ports on the SUT to a driver.
> > --
> > 2.43.0
> >
>
[-- Attachment #2: Type: text/html, Size: 6099 bytes --]
next prev parent reply other threads:[~2024-01-08 16:37 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 18:12 [PATCH v4 0/7] dts: Port scatter suite over jspewock
2023-12-18 18:12 ` [PATCH v4 1/7] dts: add required methods to testpmd_shell jspewock
2023-12-19 16:45 ` Juraj Linkeš
2023-12-21 19:37 ` Jeremy Spewock
2024-01-03 11:10 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 2/7] dts: allow passing parameters into interactive apps jspewock
2023-12-19 16:50 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2023-12-19 16:54 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 4/7] dts: add pci addresses to EAL parameters jspewock
2023-12-19 16:55 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 5/7] dts: allow configuring MTU of ports jspewock
2023-12-19 16:58 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 6/7] dts: add scatter to the yaml schema jspewock
2023-12-19 16:59 ` Juraj Linkeš
2023-12-18 18:12 ` [PATCH v4 7/7] dts: add scatter test suite jspewock
2023-12-19 17:29 ` Juraj Linkeš
2023-12-21 21:47 ` Jeremy Spewock
2024-01-03 11:14 ` Juraj Linkeš
2024-01-03 22:12 ` [PATCH v5 0/7] dts: Port scatter suite over jspewock
2024-01-03 22:12 ` [PATCH v5 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-03 22:12 ` [PATCH v5 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-03 22:12 ` [PATCH v5 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-03 22:12 ` [PATCH v5 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-03 22:12 ` [PATCH v5 5/7] dts: allow configuring MTU of ports jspewock
2024-01-03 22:12 ` [PATCH v5 6/7] dts: add scatter to the yaml schema jspewock
2024-01-03 22:12 ` [PATCH v5 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-03 22:31 ` [PATCH v6 0/7] dts: Port scatter suite over jspewock
2024-01-03 22:32 ` [PATCH v6 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-08 11:34 ` Juraj Linkeš
2024-01-08 16:36 ` Jeremy Spewock
2024-01-09 11:54 ` Juraj Linkeš
2024-01-09 14:31 ` Jeremy Spewock
2024-01-03 22:32 ` [PATCH v6 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-08 11:52 ` Juraj Linkeš
2024-01-08 16:37 ` Jeremy Spewock [this message]
2024-01-03 22:32 ` [PATCH v6 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-08 12:01 ` Juraj Linkeš
2024-01-08 16:39 ` Jeremy Spewock
2024-01-08 16:40 ` Jeremy Spewock
2024-01-03 22:32 ` [PATCH v6 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-08 14:59 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 5/7] dts: allow configuring MTU of ports jspewock
2024-01-08 15:00 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 6/7] dts: add scatter to the yaml schema jspewock
2024-01-08 15:01 ` Juraj Linkeš
2024-01-03 22:32 ` [PATCH v6 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-08 15:47 ` Juraj Linkeš
2024-01-08 16:53 ` Jeremy Spewock
2024-01-09 15:36 ` [PATCH v7 0/7] dts: Port scatter suite over jspewock
2024-01-09 15:36 ` [PATCH v7 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-10 13:18 ` Juraj Linkeš
2024-01-10 14:09 ` Jeremy Spewock
2024-01-09 15:36 ` [PATCH v7 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-09 15:36 ` [PATCH v7 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-09 15:36 ` [PATCH v7 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-09 15:36 ` [PATCH v7 5/7] dts: allow configuring MTU of ports jspewock
2024-01-09 15:36 ` [PATCH v7 6/7] dts: add scatter to the yaml schema jspewock
2024-01-09 15:36 ` [PATCH v7 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-10 13:16 ` Juraj Linkeš
2024-01-10 14:09 ` Jeremy Spewock
2024-01-10 13:22 ` [PATCH v7 0/7] dts: Port scatter suite over Juraj Linkeš
2024-01-10 14:42 ` [PATCH v8 " jspewock
2024-01-10 14:42 ` [PATCH v8 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-01-10 14:42 ` [PATCH v8 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-01-10 14:42 ` [PATCH v8 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-01-10 14:42 ` [PATCH v8 4/7] dts: add pci addresses to EAL parameters jspewock
2024-01-10 14:42 ` [PATCH v8 5/7] dts: allow configuring MTU of ports jspewock
2024-01-10 14:42 ` [PATCH v8 6/7] dts: add scatter to the yaml schema jspewock
2024-01-10 14:42 ` [PATCH v8 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-01-11 10:07 ` [PATCH v8 0/7] dts: Port scatter suite over Juraj Linkeš
2024-02-21 3:34 ` Patrick Robb
2024-03-07 15:00 ` Thomas Monjalon
2024-03-11 14:15 ` Jeremy Spewock
2024-03-11 15:43 ` [PATCH v9 " jspewock
2024-03-11 15:43 ` [PATCH v9 1/7] dts: add startup verification and forwarding modes to testpmd shell jspewock
2024-03-11 15:44 ` [PATCH v9 2/7] dts: limit EAL parameters to DPDK apps and add parameters to all apps jspewock
2024-03-11 15:44 ` [PATCH v9 3/7] dts: add optional packet filtering to scapy sniffer jspewock
2024-03-11 15:44 ` [PATCH v9 4/7] dts: add pci addresses to EAL parameters jspewock
2024-03-11 15:44 ` [PATCH v9 5/7] dts: allow configuring MTU of ports jspewock
2024-03-11 15:44 ` [PATCH v9 6/7] dts: add scatter to the yaml schema jspewock
2024-03-11 15:44 ` [PATCH v9 7/7] dts: add pmd_buffer_scatter test suite jspewock
2024-03-15 17:41 ` [PATCH v9 0/7] dts: Port scatter suite over Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAA20URyKh4PbFeR+kOtE-A7E1HkCnwfY2-x4OJ9kWimmFGrhQ@mail.gmail.com \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=juraj.linkes@pantheon.tech \
--cc=lylavoie@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).