From: Jeremy Spewock <jspewock@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net,
lijuan.tu@intel.com, wathsala.vithanage@arm.com,
probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [PATCH v6 2/2] dts: add paramiko to dependencies
Date: Thu, 13 Jul 2023 12:15:19 -0400 [thread overview]
Message-ID: <CAAA20UTHa+dAMcbD4h_2oS0jJPk2Zckg00LrZX=qdns3+sw7ZQ@mail.gmail.com> (raw)
In-Reply-To: <CAOb5WZbhYPzdUJnvXCcJthLVz7_5h1_b5F+8xN-yk47oxUJEzw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On Thu, Jul 13, 2023 at 12:06 PM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:
> On Thu, Jul 13, 2023 at 5:23 PM <jspewock@iol.unh.edu> wrote:
> >
> > From: Jeremy Spewock <jspewock@iol.unh.edu>
> >
> > added paramiko to the dependency files
> >
> > Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
> > ---
> > dts/poetry.lock | 137 +++++++++++++++++++++++++++------------------
> > dts/pyproject.toml | 1 +
> > 2 files changed, 82 insertions(+), 56 deletions(-)
> >
>
> > diff --git a/dts/pyproject.toml b/dts/pyproject.toml
> > index 50bcdb327a..c4543d5c56 100644
> > --- a/dts/pyproject.toml
> > +++ b/dts/pyproject.toml
> > @@ -13,6 +13,7 @@ warlock = "^2.0.1"
> > PyYAML = "^6.0"
> > types-PyYAML = "^6.0.8"
> > fabric = "^2.7.1"
> > +paramiko = "^3.1.0"
>
> Quick question - does the patch work with the paramiko version that
> goes with Fabric? If so, then we don't need this commit.
>
I'm not completely sure if it is needed, but I would think that it would
work without this listed in the pyproject.toml. I left it in to be less
ambiguous as to where the package actually comes from, but I am okay with
removing it if that is preferred. I'll run a test without it now quickly to
make sure it works without this commit.
>
> >
> > [tool.poetry.dev-dependencies]
> > mypy = "^0.961"
> > --
> > 2.41.0
> >
>
[-- Attachment #2: Type: text/html, Size: 2369 bytes --]
prev parent reply other threads:[~2023-07-13 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 15:21 [PATCH v6 0/2] Add DTS smoke tests jspewock
2023-07-13 15:21 ` [PATCH v6 1/2] dts: add " jspewock
2023-07-13 15:21 ` [PATCH v6 2/2] dts: add paramiko to dependencies jspewock
2023-07-13 16:05 ` Juraj Linkeš
2023-07-13 16:15 ` Jeremy Spewock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAA20UTHa+dAMcbD4h_2oS0jJPk2Zckg00LrZX=qdns3+sw7ZQ@mail.gmail.com' \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).