From: Jeremy Spewock <jspewock@iol.unh.edu>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com,
lijuan.tu@intel.com, wathsala.vithanage@arm.com,
probb@iol.unh.edu, dev@dpdk.org
Subject: Re: [RFC PATCH v1 5/5] dts: add traffic generator node to dts runner
Date: Wed, 3 May 2023 14:02:37 -0400 [thread overview]
Message-ID: <CAAA20UT_EsGyy_0_PocoaqaQxvABiZ_PMwxVQAQyBnREwTumrQ@mail.gmail.com> (raw)
In-Reply-To: <20230420093109.594704-6-juraj.linkes@pantheon.tech>
[-- Attachment #1: Type: text/plain, Size: 3729 bytes --]
Acked-by: Jeremy Spewock <jspewock@iol.unh.edu>
On Thu, Apr 20, 2023 at 5:51 AM Juraj Linkeš <juraj.linkes@pantheon.tech>
wrote:
> Initialize the TG node and do basic verification.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> dts/framework/dts.py | 42 ++++++++++++++++---------
> dts/framework/testbed_model/__init__.py | 1 +
> 2 files changed, 28 insertions(+), 15 deletions(-)
>
> diff --git a/dts/framework/dts.py b/dts/framework/dts.py
> index 0502284580..9c82bfe1f4 100644
> --- a/dts/framework/dts.py
> +++ b/dts/framework/dts.py
> @@ -9,7 +9,7 @@
> from .logger import DTSLOG, getLogger
> from .test_result import BuildTargetResult, DTSResult, ExecutionResult,
> Result
> from .test_suite import get_test_suites
> -from .testbed_model import SutNode
> +from .testbed_model import SutNode, TGNode, Node
> from .utils import check_dts_python_version
>
> dts_logger: DTSLOG = getLogger("DTSRunner")
> @@ -27,28 +27,40 @@ def run_all() -> None:
> # check the python version of the server that run dts
> check_dts_python_version()
>
> - nodes: dict[str, SutNode] = {}
> + nodes: dict[str, Node] = {}
> try:
> # for all Execution sections
> for execution in CONFIGURATION.executions:
> sut_node = None
> + tg_node = None
> if execution.system_under_test.name in nodes:
> # a Node with the same name already exists
> sut_node = nodes[execution.system_under_test.name]
> - else:
> - # the SUT has not been initialized yet
> - try:
> +
> + if execution.traffic_generator_system.name in nodes:
> + # a Node with the same name already exists
> + tg_node = nodes[execution.traffic_generator_system.name]
> +
> + try:
> + if not sut_node:
> sut_node = SutNode(execution.system_under_test)
> - result.update_setup(Result.PASS)
> - except Exception as e:
> - dts_logger.exception(
> - f"Connection to node
> {execution.system_under_test} failed."
> - )
> - result.update_setup(Result.FAIL, e)
> - else:
> - nodes[sut_node.name] = sut_node
> -
> - if sut_node:
> + if not tg_node:
> + tg_node = TGNode(execution.traffic_generator_system)
> + tg_node.verify()
> + result.update_setup(Result.PASS)
> + except Exception as e:
> + failed_node = execution.system_under_test.name
> + if sut_node:
> + failed_node = execution.traffic_generator_system.name
> + dts_logger.exception(
> + f"Creation of node {failed_node} failed."
> + )
> + result.update_setup(Result.FAIL, e)
> + else:
> + nodes[sut_node.name] = sut_node
> + nodes[tg_node.name] = tg_node
> +
> + if sut_node and tg_node:
> _run_execution(sut_node, execution, result)
>
> except Exception as e:
> diff --git a/dts/framework/testbed_model/__init__.py
> b/dts/framework/testbed_model/__init__.py
> index f54a947051..5cbb859e47 100644
> --- a/dts/framework/testbed_model/__init__.py
> +++ b/dts/framework/testbed_model/__init__.py
> @@ -20,3 +20,4 @@
> )
> from .node import Node
> from .sut_node import SutNode
> +from .tg_node import TGNode
> --
> 2.30.2
>
>
[-- Attachment #2: Type: text/html, Size: 5344 bytes --]
next prev parent reply other threads:[~2023-05-03 18:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:31 [RFC PATCH v1 0/5] dts: add tg abstractions and scapy Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 1/5] dts: add scapy dependency Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 2/5] dts: add traffic generator config Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 3/5] dts: traffic generator abstractions Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 4/5] dts: scapy traffic generator implementation Juraj Linkeš
2023-04-20 9:31 ` [RFC PATCH v1 5/5] dts: add traffic generator node to dts runner Juraj Linkeš
2023-05-03 18:02 ` Jeremy Spewock [this message]
2023-07-17 11:07 ` [PATCH v2 0/6] dts: tg abstractions and scapy tg Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 1/6] dts: add scapy dependency Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 2/6] dts: add traffic generator config Juraj Linkeš
2023-07-18 15:55 ` Jeremy Spewock
2023-07-19 12:57 ` Juraj Linkeš
2023-07-19 13:18 ` Jeremy Spewock
2023-07-17 11:07 ` [PATCH v2 3/6] dts: traffic generator abstractions Juraj Linkeš
2023-07-18 19:56 ` Jeremy Spewock
2023-07-19 13:23 ` Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 4/6] dts: add python remote interactive shell Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 5/6] dts: scapy traffic generator implementation Juraj Linkeš
2023-07-17 11:07 ` [PATCH v2 6/6] dts: add basic UDP test case Juraj Linkeš
2023-07-18 21:04 ` [PATCH v2 0/6] dts: tg abstractions and scapy tg Jeremy Spewock
2023-07-19 14:12 ` [PATCH v3 " Juraj Linkeš
2023-07-19 14:12 ` [PATCH v3 1/6] dts: add scapy dependency Juraj Linkeš
2023-07-19 14:12 ` [PATCH v3 2/6] dts: add traffic generator config Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 3/6] dts: traffic generator abstractions Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 4/6] dts: add python remote interactive shell Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 5/6] dts: scapy traffic generator implementation Juraj Linkeš
2023-07-19 14:13 ` [PATCH v3 6/6] dts: add basic UDP test case Juraj Linkeš
2023-07-20 15:21 ` Jeremy Spewock
2023-07-24 14:23 ` [PATCH v3 0/6] dts: tg abstractions and scapy tg Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAA20UT_EsGyy_0_PocoaqaQxvABiZ_PMwxVQAQyBnREwTumrQ@mail.gmail.com \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).