From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: Fix examples install path
Date: Fri, 8 Jan 2016 12:02:46 +0100 [thread overview]
Message-ID: <CAATJJ0KG3mie=Bw7052d0Nq72ve96HysqoTDt16Z7u6u3JG4YA@mail.gmail.com> (raw)
In-Reply-To: <4157952.R3xvfQ6Lix@xps13>
Hi Thomas,
sorry being away so long due to the Christmas break.
May bad assumption of being a typo was based on a coincidence combining
a) former packaging in ubuntu had it in fact under /usr/share/doc/dpdk (I
agree that just /usr/share/dpdk would be better)
b) if you just and only ran a build and install-doc (no other install
targets); the install failes just by missing the datadir
That lead me to the wrong assumption it might be in /usr/share/doc/dpdk
intentionally.
But you are right, lets fix b) instead which is just a mkdir -p in the
makefile.
Alternative patch will follow.
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
On Wed, Dec 23, 2015 at 10:37 PM, Thomas Monjalon <thomas.monjalon@6wind.com
> wrote:
> Hi,
>
> 2015-12-22 14:13, Christian Ehrhardt:
> > Depending on non-doc targets being built before and the setting of
> DESTDIR
> > the examples dir could in some cases not end up in the right target.
> > Reason is just a typo variable reference in the copy target.
> [...]
> > - $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
> > + $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(docdir)
>
> No, it was not a typo.
> Do you really think the examples code should be in the doc dir
> (i.e. /usr/share/doc/dpdk) instead of datadir (i.e. /usr/share/dpdk)?
>
prev parent reply other threads:[~2016-01-08 11:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 13:13 Christian Ehrhardt
2015-12-23 21:37 ` Thomas Monjalon
2016-01-08 11:02 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0KG3mie=Bw7052d0Nq72ve96HysqoTDt16Z7u6u3JG4YA@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).