From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: "Timothy M. Redaelli" <tredaelli@redhat.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
yskoh@mellanox.com, dev <dev@dpdk.org>,
adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library
Date: Tue, 31 Jul 2018 15:33:13 +0200 [thread overview]
Message-ID: <CAATJJ0KQzx9qP3rkDdzHc9e1WsrLc4bm7j2Dyv+kp8ZUzeNUbQ@mail.gmail.com> (raw)
In-Reply-To: <b467b0280830c94fba9078707c8af85214ce4ed7.1533042803.git.tredaelli@redhat.com>
On Tue, Jul 31, 2018 at 3:27 PM Timothy Redaelli <tredaelli@redhat.com>
wrote:
> Stripping binaries at build time is usually a bad thing since it makes
> impossible to generate (split) debug symbols and this can lead to a more
> difficult debugging.
>
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> drivers/net/mlx5/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 75bee4640..2e70dec5b 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -409,7 +409,7 @@ endif
> $(LIB_GLUE): mlx5_glue.o
> $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> -Wl,-h,$(LIB_GLUE) \
> - -s -shared -o $@ $< -libverbs -lmlx5
> + -shared -o $@ $< -libverbs -lmlx5
>
> mlx5_glue.o: mlx5_autoconf.h
>
After IRC discussion I completely agree that this shouldn't be stripped,
thanks for the fix.
Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>
> --
> 2.17.1
>
>
--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
prev parent reply other threads:[~2018-07-31 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 13:15 Timothy Redaelli
2018-07-31 13:31 ` Luca Boccassi
2018-08-01 8:29 ` Shahaf Shuler
2018-07-31 13:33 ` Christian Ehrhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAATJJ0KQzx9qP3rkDdzHc9e1WsrLc4bm7j2Dyv+kp8ZUzeNUbQ@mail.gmail.com \
--to=christian.ehrhardt@canonical.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=tredaelli@redhat.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).