From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] Duplicate config symbols
Date: Mon, 13 Jun 2016 17:09:54 +0200 [thread overview]
Message-ID: <CAATJJ0KgKO3nOYxVWs4-tHdFOJ7=Co-FWpdfNppXYCTOOrp=aA@mail.gmail.com> (raw)
In-Reply-To: <1494343.LIrEFGtHSn@xps13>
On Mon, Jun 13, 2016 at 3:47 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2016-06-13 13:50, Christian Ehrhardt:
> > I wondered multiple times now when changing a config symbol that some of
> > them are in the .config file multiple times.
> > I totally feel like I'm overlooking something, but still it might be
> worth
> > to ask.
> [...]
> > Is there any reason to do so or is this an issue in make config?
>
> It is an issue in "make config" which has never been considered important.
>
I didn't want to make it more important :-)
I'm fine with the second occurrence overwriting as it did a while now and
knowing it is not a totally unknown issue.
I had seen the old argument for not moving them out completely in the old
thread - thanks for the link - that was important to understand why they
are still there.
Also found related patches from Keith about that now.
> We could remove the first - overridden - occurences.
> I think it can be fixed in mk/rte.sdkconfig.mk.
>
You mean just filtering them eventually while keeping them where they are
so that the old request to have "the base config shows all config options"
still fulfilled - yeah that could be an approach to make everybody happy.
But then it would make for some evil unreadable sed or such, I could live
with it as is knowing it is accepted as-is.
I'll submit an RFC, but hope for someone with more dark magic to make it
nicer.
Kind Regards,
Christian
next prev parent reply other threads:[~2016-06-13 15:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 11:50 Christian Ehrhardt
2016-06-13 13:07 ` Ferruh Yigit
2016-06-13 13:47 ` Thomas Monjalon
2016-06-13 15:09 ` Christian Ehrhardt [this message]
2016-06-13 15:10 ` [dpdk-dev] [RFC] mk: filter duplicate configuration entries Christian Ehrhardt
2016-06-28 16:11 ` Ferruh Yigit
2016-06-28 16:38 ` Christian Ehrhardt
2016-06-28 16:48 ` Ferruh Yigit
2016-06-30 11:57 ` Christian Ehrhardt
2016-06-30 12:00 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2016-07-05 16:47 ` Ferruh Yigit
2016-07-05 19:47 ` Thomas Monjalon
2016-07-06 5:37 ` Christian Ehrhardt
2016-07-06 5:37 ` [dpdk-dev] [PATCH v3] " Christian Ehrhardt
2016-07-06 8:06 ` Ferruh Yigit
2016-07-06 8:12 ` Bruce Richardson
2016-07-06 8:57 ` Ferruh Yigit
2016-07-06 9:08 ` Christian Ehrhardt
2016-07-06 9:13 ` [dpdk-dev] [PATCH v4] " Christian Ehrhardt
2016-07-11 12:47 ` Thomas Monjalon
2016-07-06 9:30 ` [dpdk-dev] [PATCH v3] " Bruce Richardson
2016-06-13 16:55 ` [dpdk-dev] Duplicate config symbols Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0KgKO3nOYxVWs4-tHdFOJ7=Co-FWpdfNppXYCTOOrp=aA@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).