From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: Fix examples install
Date: Mon, 18 Jan 2016 15:55:53 +0100 [thread overview]
Message-ID: <CAATJJ0Lr53GkwnDVfbLz=fUuQr-FZUjqMvmMbaaZGuOUnfVDPQ@mail.gmail.com> (raw)
In-Reply-To: <CAATJJ0K_URNN1918kKgiQXvnge9L78KFe+uhZ+v-GnRvm=bTHw@mail.gmail.com>
Hi,
Since there was neither positive nor negative feedback so far I wanted to
ask if this patch is ok?
Especially since we had a discussion on the approach I chose in the first
approach to this issue I'd be happy about a ack/nak.
Kind Regards,
Christian
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
On Fri, Jan 8, 2016 at 12:08 PM, Christian Ehrhardt <
christian.ehrhardt@canonical.com> wrote:
> Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2
> tarball.
>
> make clean; make config T=x86_64-native-linuxapp-gcc && && make -j && make
> V=1 DESTDIR=Test install-doc
>
> In this example the install-doc fails with this:
> [...]
> Build complete [x86_64-native-linuxapp-gcc]
> make -f /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk install-doc
> cp -a /home/ubuntu/dpdk-2.2.0/examples Test/usr/local/share/dpdk
> cp: cannot create directory ‘Test/usr/local/share/dpdk’: No such file or
> directory
> /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk:160: recipe for target
> 'install-doc' failed
> make[1]: *** [install-doc] Error 1
> /home/ubuntu/dpdk-2.2.0/mk/rte.sdkroot.mk:101: recipe for target
> 'install-doc' failed
> make: *** [install-doc] Error 2
>
> Christian Ehrhardt
> Software Engineer, Ubuntu Server
> Canonical Ltd
>
> On Fri, Jan 8, 2016 at 12:03 PM, Christian Ehrhardt <
> christian.ehrhardt@canonical.com> wrote:
>
>> Depending on non-doc targets being built before and the setting of DESTDIR
>> the copy of the examples dir being part of install-doc could in some
>> cases fail
>> with a non existant "$(DESTDIR)$(datadir)" target directory.
>> Add the conditional rte_mkdir for that to avoid the issue.
>>
>> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
>> ---
>>
>> [diffstat]
>> rte.sdkinstall.mk | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> [diff]
>> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
>> index c159bf7..68e56b6 100644
>> --- a/mk/rte.sdkinstall.mk
>> +++ b/mk/rte.sdkinstall.mk
>> @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),)
>> $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides)
>> $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides
>> endif
>> + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir))
>> $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)
>>
>
>
next prev parent reply other threads:[~2016-01-18 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 11:03 Christian Ehrhardt
2016-01-08 11:08 ` Christian Ehrhardt
2016-01-18 14:55 ` Christian Ehrhardt [this message]
2016-01-19 8:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATJJ0Lr53GkwnDVfbLz=fUuQr-FZUjqMvmMbaaZGuOUnfVDPQ@mail.gmail.com' \
--to=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).