From: Santosh Shukla <sshukla@mvista.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 6/7] eal: pci: export pci_map_device
Date: Wed, 13 Jan 2016 20:14:17 +0530 [thread overview]
Message-ID: <CAAyOgsaO=fFx8=hCXpZkjMD8nKbLOYCWVJfNbpsxm8vn1GY3cA@mail.gmail.com> (raw)
In-Reply-To: <20160112090543.GS26062@yliu-dev.sh.intel.com>
On Tue, Jan 12, 2016 at 2:35 PM, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:
> On Tue, Jan 12, 2016 at 04:40:43PM +0800, Yuanhan Liu wrote:
>> On Tue, Jan 12, 2016 at 09:31:05AM +0100, David Marchand wrote:
>> > On Tue, Jan 12, 2016 at 7:59 AM, Yuanhan Liu <yuanhan.liu@linux.intel.com>
>> > wrote:
>> >
>> > Normally we could set RTE_PCI_DRV_NEED_MAPPING flag so that eal will
>> > invoke pci_map_device internally for us. From that point view, there
>> > is no need to export pci_map_device.
>> >
>> > However, for virtio pmd driver, which is designed to work without
>> > binding UIO (or something similar first), pci_map_device() will fail,
>> > which ends up with virtio pmd driver being skipped. Therefore, we can
>> > not set RTE_PCI_DRV_NEED_MAPPING blindly at virtio pmd driver.
>> >
>> > Therefore, this patch exports pci_map_device, and let virtio pmd
>> > call it when necessary.
>> >
>> >
>> > Well, if you introduce map function, I suppose, for hotplug, you would need
>> > unmap.
>>
>> Good remind. Thanks. I will export pci_unmap_device as well.
>
> And here you go.
>
> --yliu
>
> -- >8 --
> From aa3d9d0fa827781d1563fd4c06ba04a8fafdc41c Mon Sep 17 00:00:00 2001
> From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Date: Mon, 11 Jan 2016 16:51:35 +0800
> Subject: [PATCH] eal: pci: export pci_[un]map_device
>
> Normally we could set RTE_PCI_DRV_NEED_MAPPING flag so that eal will
> invoke pci_map_device internally for us. From that point view, there
> is no need to export pci_map_device.
>
> However, for virtio pmd driver, which is designed to work without
> binding UIO (or something similar first), pci_map_device() will fail,
> which ends up with virtio pmd driver being skipped. Therefore, we can
> not set RTE_PCI_DRV_NEED_MAPPING blindly at virtio pmd driver.
>
> Therefore, this patch exports pci_map_device, and let virtio pmd
> call it when necessary.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
> v2: - export pci_unmap_device as well
>
> - Add few more comments about rte_eal_pci_map_device().
This patch tested for vfio-noIOMMU mode for arm64 platform.
Tested-By: Santosh Shukla <sshukla@mvista.com>
next prev parent reply other threads:[~2016-01-13 14:44 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 3:54 [dpdk-dev] [PATCH 0/6 for 2.3] initial virtio 1.0 enabling Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 1/6] virtio: don't set vring address again at queue startup Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 2/6] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2015-12-29 11:31 ` Tan, Jianfeng
2015-12-30 3:45 ` Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 3/6] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 4/6] viritio: switch to 64 bit features Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 5/6] virtio: set RTE_PCI_DRV_NEED_MAPPING flag Yuanhan Liu
2015-12-10 3:54 ` [dpdk-dev] [PATCH 6/6] virtio: add virtio v1.0 support Yuanhan Liu
2015-12-29 11:39 ` Tan, Jianfeng
2015-12-30 3:40 ` Yuanhan Liu
2015-12-10 3:58 ` [dpdk-dev] [PATCH 0/6 for 2.3] initial virtio 1.0 enabling Yuanhan Liu
2015-12-29 11:19 ` Tan, Jianfeng
2015-12-30 3:53 ` Yuanhan Liu
2016-01-04 3:55 ` Xu, Qian Q
2016-01-04 4:16 ` Yuanhan Liu
2016-01-12 6:58 ` [dpdk-dev] [PATCH v2 0/7] virtio 1.0 enabling for virtio pmd driver Yuanhan Liu
2016-01-12 6:58 ` [dpdk-dev] [PATCH v2 1/7] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-01-12 6:58 ` [dpdk-dev] [PATCH v2 2/7] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-01-12 6:59 ` [dpdk-dev] [PATCH v2 3/7] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-01-12 6:59 ` [dpdk-dev] [PATCH v2 4/7] viritio: switch to 64 bit features Yuanhan Liu
2016-01-12 6:59 ` [dpdk-dev] [PATCH v2 5/7] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-01-12 6:59 ` [dpdk-dev] [PATCH v2 6/7] eal: pci: export pci_map_device Yuanhan Liu
2016-01-12 8:31 ` David Marchand
2016-01-12 8:40 ` Yuanhan Liu
2016-01-12 9:05 ` Yuanhan Liu
2016-01-13 14:44 ` Santosh Shukla [this message]
2016-01-12 6:59 ` [dpdk-dev] [PATCH v2 7/7] virtio: add 1.0 support Yuanhan Liu
2016-01-13 3:31 ` Tetsuya Mukawa
2016-01-13 9:38 ` Yuanhan Liu
2016-01-14 7:47 ` Xie, Huawei
2016-01-14 7:50 ` Yuanhan Liu
2016-01-14 7:51 ` Xie, Huawei
2016-01-14 7:58 ` Yuanhan Liu
2016-01-14 8:08 ` Xie, Huawei
2016-01-14 8:22 ` Yuanhan Liu
2016-01-14 8:28 ` Xie, Huawei
2016-01-14 7:50 ` Xie, Huawei
2016-01-14 8:38 ` Yuanhan Liu
2016-01-12 7:07 ` [dpdk-dev] [PATCH v2 0/7] virtio 1.0 enabling for virtio pmd driver Yuanhan Liu
2016-01-14 4:27 ` Tetsuya Mukawa
2016-01-14 5:59 ` Yuanhan Liu
2016-01-14 6:09 ` Tan, Jianfeng
2016-01-14 6:41 ` Tetsuya Mukawa
2016-01-18 9:04 ` Tetsuya Mukawa
2016-01-14 6:45 ` Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 0/8] " Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 1/8] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 2/8] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 3/8] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 4/8] viritio: switch to 64 bit features Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 5/8] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 6/8] eal: pci: export pci_[un]map_device Yuanhan Liu
2016-01-14 7:45 ` Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 7/8] virtio: add 1.0 support Yuanhan Liu
2016-01-14 7:42 ` [dpdk-dev] [PATCH v3 8/8] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c Yuanhan Liu
2016-01-16 10:08 ` Santosh Shukla
2016-01-17 14:07 ` Santosh Shukla
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 0/8] virtio 1.0 enabling for virtio pmd driver Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 1/8] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 2/8] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-01-18 17:21 ` Xie, Huawei
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 3/8] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 4/8] viritio: switch to 64 bit features Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 5/8] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 6/8] eal: pci: export pci_[un]map_device Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 7/8] virtio: add 1.0 support Yuanhan Liu
2016-01-18 16:38 ` Xie, Huawei
2016-01-18 16:50 ` Xie, Huawei
2016-01-19 5:55 ` Yuanhan Liu
2016-01-19 7:44 ` Xie, Huawei
2016-01-19 7:54 ` Yuanhan Liu
2016-01-19 8:02 ` Xie, Huawei
2016-01-18 17:07 ` Xie, Huawei
2016-01-19 1:36 ` Yuanhan Liu
2016-01-19 1:51 ` Xie, Huawei
2016-01-19 2:46 ` Yuanhan Liu
2016-01-19 2:48 ` Xie, Huawei
2016-01-19 5:54 ` Yuanhan Liu
2016-01-15 4:36 ` [dpdk-dev] [PATCH v4 8/8] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c Yuanhan Liu
2016-01-15 8:57 ` Xu, Qian Q
2016-01-18 8:04 ` [dpdk-dev] [PATCH v4 0/8] virtio 1.0 enabling for virtio pmd driver Tetsuya Mukawa
2016-01-19 8:11 ` [dpdk-dev] [PATCH v5 0/9] " Yuanhan Liu
2016-01-19 8:11 ` [dpdk-dev] [PATCH v5 1/9] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-01-19 8:11 ` [dpdk-dev] [PATCH v5 2/9] virtio: define offset as size_t type Yuanhan Liu
2016-01-19 8:11 ` [dpdk-dev] [PATCH v5 3/9] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 4/9] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 5/9] viritio: switch to 64 bit features Yuanhan Liu
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 6/9] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 7/9] eal: pci: export pci_[un]map_device Yuanhan Liu
2016-01-19 8:17 ` David Marchand
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 8/9] virtio: add 1.0 support Yuanhan Liu
2016-01-21 11:37 ` Thomas Monjalon
2016-01-27 3:49 ` Yuanhan Liu
2016-01-21 11:49 ` Thomas Monjalon
2016-01-27 3:46 ` Yuanhan Liu
2016-01-27 8:11 ` Thomas Monjalon
2016-01-19 8:12 ` [dpdk-dev] [PATCH v5 9/9] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c Yuanhan Liu
2016-01-19 8:55 ` [dpdk-dev] [PATCH v5 0/9] virtio 1.0 enabling for virtio pmd driver Xie, Huawei
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 " Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 1/9] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 2/9] virtio: define offset as size_t type Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 3/9] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 4/9] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 5/9] viritio: switch to 64 bit features Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 6/9] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 7/9] eal: pci: export pci_[un]map_device Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 8/9] virtio: add 1.0 support Yuanhan Liu
2016-01-28 7:54 ` [dpdk-dev] [PATCH v6 9/9] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c Yuanhan Liu
2016-02-02 10:46 ` [dpdk-dev] [PATCH v6 0/9] virtio 1.0 enabling for virtio pmd driver Thomas Monjalon
2016-02-02 13:00 ` Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 " Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 1/9] virtio: don't set vring address again at queue startup Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 2/9] virtio: define offset as size_t type Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 3/9] virtio: introduce struct virtio_pci_ops Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 4/9] virtio: move left pci stuff to virtio_pci.c Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 5/9] viritio: switch to 64 bit features Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 6/9] virtio: retrieve hdr_size from hw->vtnet_hdr_size Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 7/9] eal: pci: export pci_[un]map_device Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 8/9] virtio: add 1.0 support Yuanhan Liu
2016-02-02 13:48 ` [dpdk-dev] [PATCH v7 9/9] virtio: move VIRTIO_READ/WRITE_REG_X into virtio_pci.c Yuanhan Liu
2016-02-03 15:09 ` [dpdk-dev] [PATCH v7 0/9] virtio 1.0 enabling for virtio pmd driver Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAyOgsaO=fFx8=hCXpZkjMD8nKbLOYCWVJfNbpsxm8vn1GY3cA@mail.gmail.com' \
--to=sshukla@mvista.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).