From: Stefan Puiu <stefan.puiu@gmail.com>
To: Yong Wang <yongwang@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"mac_leehk@yahoo.com.hk" <mac_leehk@yahoo.com.hk>
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: fix Rx deadlock
Date: Mon, 12 Dec 2016 10:27:29 +0200 [thread overview]
Message-ID: <CACKs7VAJDu6aMY6tLJXcM4doS8diZkAOidVCRZwR6u1RTuRaDQ@mail.gmail.com> (raw)
In-Reply-To: <BY2PR05MB2359E5B448AFCF17B7713738AF8C0@BY2PR05MB2359.namprd05.prod.outlook.com>
Hello and thanks for reviewing the patch.
On Wed, Nov 30, 2016 at 6:59 AM, Yong Wang <yongwang@vmware.com> wrote:
[...]
> I think a more accurate description is that the particular descriptor's generation bit never got flipped properly when an mbuf failed to be refilled which caused the rx stuck, rather than vmxnet3_post_rx_bufs() not being called afterwards.
>
Not sure if this kind of level of detail is useful, but if you can
think of a better explanation to put in the changelist, I can add it.
I see the generation bit not flipping as a symptom, while the core
problem is the hardware can't write to the descriptor. I felt the
explanation was going into too much detail anyway, so I've reworded it
a bit for v2. Let me know what you think.
Thanks,
Stefan.
next prev parent reply other threads:[~2016-12-12 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 10:46 Stefan Puiu
2016-11-30 4:59 ` Yong Wang
2016-12-12 8:27 ` Stefan Puiu [this message]
2016-12-12 18:17 ` Yong Wang
2016-12-12 8:21 ` [dpdk-dev] [PATCH v2] " Stefan Puiu
2016-12-16 15:36 ` [dpdk-dev] [PATCH v3] " Stefan Puiu
2016-12-16 17:47 ` Yong Wang
2016-12-19 9:40 ` [dpdk-dev] [PATCH v4] " Stefan Puiu
2016-12-19 10:41 ` Ferruh Yigit
2016-12-19 12:26 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2016-11-14 10:40 [dpdk-dev] [PATCH] " Stefan Puiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACKs7VAJDu6aMY6tLJXcM4doS8diZkAOidVCRZwR6u1RTuRaDQ@mail.gmail.com \
--to=stefan.puiu@gmail.com \
--cc=dev@dpdk.org \
--cc=mac_leehk@yahoo.com.hk \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).