From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>,
lihuisong@huawei.com, Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability
Date: Mon, 29 Mar 2021 07:12:55 -0700 [thread overview]
Message-ID: <CACZ4nhs0Enm3C8isMWOuYZz6d3u3fqv1zfi++Ld8UH+5nYLQbg@mail.gmail.com> (raw)
In-Reply-To: <20210329072854.450188-1-thomas@monjalon.net>
[-- Attachment #1: Type: text/plain, Size: 2316 bytes --]
On Mon, Mar 29, 2021 at 12:29 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The flag ETH_LINK_SPEED_AUTONEG is 0,
> so it cannot be used in a capability bitmap.
>
> Having 0 in speed capability means all speeds are accepted.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 --
For bnxt
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> drivers/net/mlx5/linux/mlx5_ethdev_os.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index f1dd40591f..a2debdbb64 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -889,8 +889,6 @@ uint32_t bnxt_get_speed_capabilities(struct bnxt *bp)
> if (bp->link_info->auto_mode ==
> HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_NONE)
> speed_capa |= ETH_LINK_SPEED_FIXED;
> - else
> - speed_capa |= ETH_LINK_SPEED_AUTONEG;
>
> return speed_capa;
> }
> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> index 0e8de9439e..58d56913ae 100644
> --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c
> @@ -409,8 +409,6 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev,
> else
> dev_link.link_speed = link_speed;
> priv->link_speed_capa = 0;
> - if (edata.supported & SUPPORTED_Autoneg)
> - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG;
> if (edata.supported & (SUPPORTED_1000baseT_Full |
> SUPPORTED_1000baseKX_Full))
> priv->link_speed_capa |= ETH_LINK_SPEED_1G;
> @@ -517,8 +515,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev,
> sc = ecmd->link_mode_masks[0] |
> ((uint64_t)ecmd->link_mode_masks[1] << 32);
> priv->link_speed_capa = 0;
> - if (sc & MLX5_BITSHIFT(ETHTOOL_LINK_MODE_Autoneg_BIT))
> - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG;
> if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseT_Full_BIT) |
> MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT)))
> priv->link_speed_capa |= ETH_LINK_SPEED_1G;
> --
> 2.30.1
>
next prev parent reply other threads:[~2021-03-29 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 4:02 [dpdk-dev] Questions about reporting auto-negotiation capability Huisong Li
2021-03-29 7:03 ` Thomas Monjalon
2021-03-29 7:19 ` Thomas Monjalon
2021-03-29 11:44 ` Huisong Li
2021-03-29 12:05 ` Thomas Monjalon
2021-03-29 14:18 ` Ajit Khaparde
2021-03-29 7:28 ` [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability Thomas Monjalon
2021-03-29 14:12 ` Ajit Khaparde [this message]
2021-04-01 13:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhs0Enm3C8isMWOuYZz6d3u3fqv1zfi++Ld8UH+5nYLQbg@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=lihuisong@huawei.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).