From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Randy Schacher <stuart.schacher@broadcom.com>,
Farah Smith <farah.smith@broadcom.com>,
Shahaji Bhosle <sbhosle@broadcom.com>,
dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH v3 04/11] net/bnxt: update Truflow core
Date: Wed, 28 Jun 2023 09:35:25 -0700 [thread overview]
Message-ID: <CACZ4nhsKp32myagfQwjU76YGAbiL03r=WLL+h3bUfJZ4XEPXwQ@mail.gmail.com> (raw)
In-Reply-To: <1826961.atdPhlSkOF@thomas>
[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]
On Sat, Jun 10, 2023 at 11:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 04/05/2023 19:36, Ajit Khaparde:
> > From: Randy Schacher <stuart.schacher@broadcom.com>
> >
> > Update TruFlow core code to:
> > - Add shared session management
> > - Add SRAM session management
> > - Add dynamic TCAM management
> > - Add shared TCAM session management
> > - Add Hot Upgrade support
> > - Update copyright year
>
> I suppose you can update the date in the previous patch
> for the whole driver.
To some extent the idea was to update the date in the patch when the
code change was happening, instead of a blanket date change.
>
> Also this patch is removing some blank lines out of Truflow.
> And I don't understand the need for removing the blank lines
> before the last #ifdef of the file.
The template files are auto generated using a bunch of scripts.
What we are seeing is probably because of that.
But we have cleaned up many of those in the v4 submission.
>
> More important, you are doing huge update of many different things
> in one patch.
> It looks like you don't want the community to follow what you are doing.
Actually, no.
As I mentioned above, most of the truflow files are auto generated.
The reason for bundling some of the changes together was to avoid
multiple patches hitting the mail server patch size limit.
We thought it might be better to take the patch size hit on one patch
instead of multiple patches.
We are working on some design changes to the auto generation scripts
which will avoid big churn in the template patches in the future.
>
> For info, there are other things to fix in this patchset:
> Error: Incorrect indent at drivers/net/bnxt/tf_ulp/generic_templates/meson.build
> rte_flow doc out of sync for bnxt
> action set_mac_dst
> action set_mac_src
> You can run the following script to catch these issues:
> devtools/check-meson.py
> devtools/check-doc-vs-code.sh
We have addressed these in the v4 version.
Thanks
>
>
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
next prev parent reply other threads:[~2023-06-28 16:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 17:36 [PATCH v3 00/11] sync Truflow support with latest release Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 01/11] net/bnxt: remove deprecated features Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 02/11] net/bnxt: update bnxt hsi structure Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 03/11] net/bnxt: update copyright date and cleanup whitespace Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 04/11] net/bnxt: update Truflow core Ajit Khaparde
2023-06-10 18:32 ` Thomas Monjalon
2023-06-28 16:29 ` [PATCH v4 00/11] sync Truflow support with latest release Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 01/11] net/bnxt: remove deprecated features Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 02/11] net/bnxt: update bnxt hsi structure Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 03/11] net/bnxt: update copyright date and cleanup whitespace Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 04/11] net/bnxt: update Truflow core Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 05/11] net/bnxt: update ULP shared session support Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 06/11] net/bnxt: add RSS and Queue action in TruFLow Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 07/11] net/bnxt: add support for rte meter Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 08/11] net/bnxt: update PTP support on Thor Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 09/11] net/bnxt: fix multi-root card support Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 10/11] net/bnxt: add support for eCPRI packet parsing Ajit Khaparde
2023-06-28 16:29 ` [PATCH v4 11/11] net/bnxt: set RSS config based on RSS mode Ajit Khaparde
2023-06-28 16:35 ` Ajit Khaparde [this message]
2023-06-28 19:07 ` [PATCH v3 04/11] net/bnxt: update Truflow core Thomas Monjalon
2023-06-29 4:30 ` Ajit Khaparde
2023-06-30 12:16 ` Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 05/11] net/bnxt: update ULP shared session support Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 06/11] net/bnxt: add RSS and Queue action in TruFLow Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 07/11] net/bnxt: add support for rte meter Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 08/11] net/bnxt: update PTP support on Thor Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 09/11] net/bnxt: fix multi-root card support Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 10/11] net/bnxt: add support for eCPRI packet parsing Ajit Khaparde
2023-05-04 17:36 ` [PATCH v3 11/11] net/bnxt: set RSS config based on RSS mode Ajit Khaparde
2023-05-10 17:16 ` [PATCH v3 00/11] sync Truflow support with latest release Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhsKp32myagfQwjU76YGAbiL03r=WLL+h3bUfJZ4XEPXwQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=farah.smith@broadcom.com \
--cc=sbhosle@broadcom.com \
--cc=stuart.schacher@broadcom.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).