From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Subject: Re: [PATCH] net/bnxt: fix ulp parser to ignore segment offset
Date: Tue, 29 Mar 2022 16:22:12 -0700 [thread overview]
Message-ID: <CACZ4nhsQU6fhvufvoJ1Zjt1h8AdGHtnwXsMWdFz2CmCL2tzF4A@mail.gmail.com> (raw)
In-Reply-To: <20220314212334.93753-1-ajit.khaparde@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
On Mon, Mar 14, 2022 at 2:23 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> From: Shuanglin Wang <shuanglin.wang@broadcom.com>
>
> Fix ulp parser to ignore segment_offset of IPV4 header.
> Currently the IPV4 handler is assuming default setting,
> which causes the flow table to be updated incorrectly.
>
> Fixes: 741172be52de ("net/bnxt: refactor flow parser in ULP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shuanglin Wang <shuanglin.wang@broadcom.com>
> Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> index f4274dd634..9edf3e8799 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c
> @@ -1096,7 +1096,7 @@ ulp_rte_ipv4_hdr_handler(const struct rte_flow_item *item,
> hdr.fragment_offset),
> ulp_deference_struct(ipv4_mask,
> hdr.fragment_offset),
> - ULP_PRSR_ACT_DEFAULT);
> + ULP_PRSR_ACT_MASK_IGNORE);
>
> size = sizeof(((struct rte_flow_item_ipv4 *)NULL)->hdr.time_to_live);
> ulp_rte_prsr_fld_mask(params, &idx, size,
> --
> 2.32.0 (Apple Git-132)
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
prev parent reply other threads:[~2022-03-29 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:23 Ajit Khaparde
2022-03-29 23:22 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhsQU6fhvufvoJ1Zjt1h8AdGHtnwXsMWdFz2CmCL2tzF4A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).