From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: kirankumark@marvell.com
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
beilei.xing@intel.com, chas3@att.com,
cloud.wangxiaoyun@huawei.com, cristian.dumitrescu@intel.com,
dev@dpdk.org, grive@u256.net, hemant.agrawal@nxp.com,
humin29@huawei.com, hyonkim@cisco.com,
jasvinder.singh@intel.com, jerinj@marvell.com,
jia.guo@intel.com, jingjing.wu@intel.com, johndale@cisco.com,
keith.wiles@intel.com, lironh@marvell.com, matan@mellanox.com,
ndabilpuram@marvell.com, orika@mellanox.com,
qi.z.zhang@intel.com, qiming.yang@intel.com,
rahul.lakkireddy@chelsio.com, rmody@marvell.com,
rosen.xu@intel.com, sachin.saxena@nxp.com, shahafs@mellanox.com,
shshaikh@marvell.com, somnath.kotur@broadcom.com,
viacheslavo@mellanox.com, wei.zhao1@intel.com,
xavier.huwei@huawei.com, xuanziyang2@huawei.com,
yisen.zhuang@huawei.com, zhouguoyang@huawei.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add level support for RSS offload types
Date: Sat, 8 Aug 2020 07:40:12 -0700 [thread overview]
Message-ID: <CACZ4nhsk-zwxb1ee7jX-1cz6k5R_-WuFeSrKD73ptthfXqq5KQ@mail.gmail.com> (raw)
In-Reply-To: <20200808143631.1704756-1-kirankumark@marvell.com>
On Sat, Aug 8, 2020 at 7:36 AM <kirankumark@marvell.com> wrote:
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> This patch reserves 2 bits as input selection to select Inner and
> outer layers for RSS computation. It is combined with existing
> ETH_RSS_* to choose Inner or outer layers for L2, L3 and L4.
How do you plan to use this? Do you need to make any changes to testpmd?
> This functionality already exists in rte_flow through level parameter in
> RSS action configuration rte_flow_action_rss.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
> v2 changes:
> * Reserved bit 50 & 51
>
> lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.h
> b/lib/librte_ethdev/rte_ethdev.h
> index d29930fd8..28184cc85 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -552,6 +552,33 @@ struct rte_eth_rss_conf {
> #define RTE_ETH_RSS_L3_PRE64 (1ULL << 53)
> #define RTE_ETH_RSS_L3_PRE96 (1ULL << 52)
>
> +/*
> + * We use the following macros to combine with the above layers to choose
> + * inner and outer layers or both for RSS computation.
> + * Note: Default is 0: inner layers, 1: outer layers, 2: both
> + * bit 50 and 51 are reserved for this.
> + */
> +
> +/**
> + * Level 0, It basically stands for the innermost encapsulation level RSS
> + * can be performed on according to PMD and device capabilities.
> + */
> +#define ETH_RSS_LEVEL_INNER (0ULL << 50)
> +/**
> + * Level 1, It basically stands for the outermost encapsulation level RSS
> + * can be performed on according to PMD and device capabilities.
> + */
> +#define ETH_RSS_LEVEL_OUTER (1ULL << 50)
> +/**
> + * Level 2, It basically stands for the both inner and outermost
> + * encapsulation level RSS can be performed on according to PMD and
> + * device capabilities.
> + */
> +#define ETH_RSS_LEVEL_INNER_OUTER (2ULL << 50)
> +#define ETH_RSS_LEVEL_MASK (3ULL << 50)
> +
> +#define ETH_RSS_LEVEL(rss_hf) ((rss_hf & ETH_RSS_LEVEL_MASK) >> 50)
> +
> /**
> * For input set change of hash filter, if SRC_ONLY and DST_ONLY of
> * the same level are used simultaneously, it is the same case as
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2020-08-08 14:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 12:04 [dpdk-dev] [PATCH " kirankumark
2020-08-07 12:04 ` [dpdk-dev] [PATCH 2/2] net/octeontx2: add rss hash level support kirankumark
2020-08-08 14:36 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add level support for RSS offload types kirankumark
2020-08-08 14:36 ` [dpdk-dev] [PATCH v2 2/2] net/octeontx2: add rss hash level support kirankumark
2020-08-08 14:40 ` Ajit Khaparde [this message]
2020-08-14 3:55 ` [dpdk-dev] [EXT] Re: [PATCH v2 1/2] ethdev: add level support for RSS offload types Kiran Kumar Kokkilagadda
2020-08-18 7:21 ` [dpdk-dev] [PATCH v3 " kirankumark
2020-08-18 7:21 ` [dpdk-dev] [PATCH v3 2/2] net/octeontx2: add rss hash level support kirankumark
2020-08-18 10:03 ` Jerin Jacob
2020-08-18 10:10 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2020-08-18 10:31 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add level support for RSS offload types kirankumark
2020-08-18 10:31 ` [dpdk-dev] [PATCH v4 2/2] net/octeontx2: add rss hash level support kirankumark
2020-08-18 10:52 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add level support for RSS offload types Jeff Guo
2020-08-18 11:43 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2020-08-19 6:04 ` [dpdk-dev] [PATCH v5 " kirankumark
2020-08-19 6:04 ` [dpdk-dev] [PATCH v5 2/2] net/octeontx2: add rss hash level support kirankumark
2020-08-20 3:19 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add level support for RSS offload types Ajit Khaparde
2020-08-21 10:57 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2020-08-21 11:03 ` [dpdk-dev] [PATCH v6 1/3] " kirankumark
2020-08-21 11:03 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: support ethdev rss level config kirankumark
2020-08-29 0:48 ` Ajit Khaparde
2020-08-21 11:03 ` [dpdk-dev] [PATCH v6 3/3] net/octeontx2: add rss hash level support kirankumark
2020-08-29 14:52 ` [dpdk-dev] [PATCH v6 1/3] ethdev: add level support for RSS offload types Andrew Rybchenko
2020-09-01 13:23 ` Ferruh Yigit
2020-09-01 3:27 ` [dpdk-dev] [PATCH v7 " kirankumark
2020-09-01 3:27 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: support ethdev rss level config kirankumark
2020-09-01 3:27 ` [dpdk-dev] [PATCH v7 3/3] net/octeontx2: add rss hash level support kirankumark
2020-09-01 13:37 ` [dpdk-dev] [PATCH v7 1/3] ethdev: add level support for RSS offload types Ferruh Yigit
2020-09-01 14:27 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
2020-09-01 14:44 ` Ferruh Yigit
2020-09-01 14:54 ` Ferruh Yigit
2020-09-01 17:11 ` Ajit Khaparde
2020-09-03 10:11 ` Kiran Kumar Kokkilagadda
2020-09-03 13:14 ` Ferruh Yigit
2020-09-07 8:12 ` Andrew Rybchenko
2020-09-08 19:40 ` Ajit Khaparde
2020-09-17 2:07 ` [dpdk-dev] [PATCH v8 " kirankumark
2020-09-17 2:07 ` [dpdk-dev] [PATCH v8 2/3] app/testpmd: support ethdev rss level config kirankumark
2020-09-17 18:58 ` Ajit Khaparde
2020-09-17 2:07 ` [dpdk-dev] [PATCH v8 3/3] net/octeontx2: add rss hash level support kirankumark
2020-09-17 9:36 ` [dpdk-dev] [PATCH v8 1/3] ethdev: add level support for RSS offload types Andrew Rybchenko
2020-09-17 18:56 ` Ajit Khaparde
2020-09-18 11:40 ` Ferruh Yigit
2020-08-18 17:39 ` [dpdk-dev] [PATCH v3 1/2] " Ajit Khaparde
2020-08-19 3:58 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhsk-zwxb1ee7jX-1cz6k5R_-WuFeSrKD73ptthfXqq5KQ@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=chas3@att.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=grive@u256.net \
--cc=hemant.agrawal@nxp.com \
--cc=humin29@huawei.com \
--cc=hyonkim@cisco.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinj@marvell.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=keith.wiles@intel.com \
--cc=kirankumark@marvell.com \
--cc=lironh@marvell.com \
--cc=matan@mellanox.com \
--cc=ndabilpuram@marvell.com \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=shahafs@mellanox.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=wei.zhao1@intel.com \
--cc=xavier.huwei@huawei.com \
--cc=xuanziyang2@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).