From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure
Date: Wed, 27 Oct 2021 21:24:45 -0700 [thread overview]
Message-ID: <CACZ4nht36i=zhhWAsZRVsBWDdYGKzBNetoOj+dM+Qc9a1iWkpQ@mail.gmail.com> (raw)
In-Reply-To: <20211028022944.26402-1-kalesh-anakkur.purayil@broadcom.com>
On Wed, Oct 27, 2021 at 7:09 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> With commit 239695f754cb ("net/bnxt: enhance RSS action support"),
> when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting
> flow error using "rte_flow_error_set".
>
> Fixes: 239695f754cb ("net/bnxt: enhance RSS action support")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index 9526a8f..b3c68b1 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
>
> skip_rss_table:
> rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic);
> + if (rc != 0) {
> + rte_flow_error_set(error,
> + -rc,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "VNIC RSS configure failed");
> + rc = -rte_errno;
> + goto ret;
> + }
> ret:
> return rc;
> }
> @@ -1515,7 +1524,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
> /* RSS config update requested */
> rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error);
> if (rc != 0)
> - return -rte_errno;
> + goto ret;
>
> filter->dst_id = vnic->fw_vnic_id;
> break;
> --
> 2.10.1
>
prev parent reply other threads:[~2021-10-28 4:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 2:29 Kalesh A P
2021-10-28 4:24 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nht36i=zhhWAsZRVsBWDdYGKzBNetoOj+dM+Qc9a1iWkpQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).