From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: Piotr Kubaj <pkubaj@freebsd.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: rename a member to avoid conflict
Date: Thu, 11 Mar 2021 15:59:29 -0800 [thread overview]
Message-ID: <CACZ4nhu+kFgqN1S4d3ifi-PbbP2JTayX7Rodnjc4b=jmRZESMQ@mail.gmail.com> (raw)
In-Reply-To: <20210311233033.67152-1-ajit.khaparde@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]
On Thu, Mar 11, 2021 at 3:30 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Address build issues with Clang and without glibc on ppc64le.
> Vector can be a keyword and should not be used in code.
> Renaming it to avoid conflict.
>
> Reported-by: Piotr Kubaj <pkubaj@FreeBSD.org>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_irq.c | 2 +-
> drivers/net/bnxt/bnxt_irq.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
> index a29ac28590..8abbadb3d1 100644
> --- a/drivers/net/bnxt/bnxt_irq.c
> +++ b/drivers/net/bnxt/bnxt_irq.c
> @@ -151,7 +151,7 @@ int bnxt_setup_int(struct bnxt *bp)
> sizeof(struct bnxt_irq), 0);
> if (bp->irq_tbl) {
> for (i = 0; i < total_vecs; i++) {
> - bp->irq_tbl[i].vector = i;
> + bp->irq_tbl[i].vector_idx = i;
> snprintf(bp->irq_tbl[i].name, len,
> "%s-%d", bp->eth_dev->device->name, i);
> bp->irq_tbl[i].handler = bnxt_int_handler;
> diff --git a/drivers/net/bnxt/bnxt_irq.h b/drivers/net/bnxt/bnxt_irq.h
> index 7b02f30973..53d9198858 100644
> --- a/drivers/net/bnxt/bnxt_irq.h
> +++ b/drivers/net/bnxt/bnxt_irq.h
> @@ -8,7 +8,7 @@
>
> struct bnxt_irq {
> rte_intr_callback_fn handler;
> - unsigned int vector;
> + unsigned int vector_idx;
> uint8_t requested;
> char name[RTE_ETH_NAME_MAX_LEN + 2];
> };
> --
> 2.21.1 (Apple Git-122.3)
>
next prev parent reply other threads:[~2021-03-11 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 23:30 Ajit Khaparde
2021-03-11 23:59 ` Ajit Khaparde [this message]
2021-03-12 0:33 ` Piotr Kubaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhu+kFgqN1S4d3ifi-PbbP2JTayX7Rodnjc4b=jmRZESMQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=pkubaj@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).