From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix null pointer dereferences
Date: Tue, 20 Jul 2021 14:35:40 -0700 [thread overview]
Message-ID: <CACZ4nhu4xss_GDFnKXBdgPyTe=hrey-jwM1TUt6M3+cq1h3bHQ@mail.gmail.com> (raw)
In-Reply-To: <20210720162158.5883-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
On Tue, Jul 20, 2021 at 9:01 AM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Coverity reports that pointer "cpr->cp_ring_struct" may be
> dereferenced with null value. This patch fixes this.
>
> Coverity issue: 372063
> Fixes: 5ed30db87fa8 ("net/bnxt: fix missing barriers in completion
> handling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
>
Patch applied to dpdk-next-net-brcm
> ---
> drivers/net/bnxt/bnxt_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
> index ebdac83..122a1f9 100644
> --- a/drivers/net/bnxt/bnxt_irq.c
> +++ b/drivers/net/bnxt/bnxt_irq.c
> @@ -33,7 +33,6 @@ void bnxt_int_handler(void *param)
> return;
>
> raw_cons = cpr->cp_raw_cons;
> - cp_ring_size = cpr->cp_ring_struct->ring_size;
> pthread_mutex_lock(&bp->def_cp_lock);
> while (1) {
> if (!cpr || !cpr->cp_ring_struct || !cpr->cp_db.doorbell) {
> @@ -46,6 +45,7 @@ void bnxt_int_handler(void *param)
> return;
> }
>
> + cp_ring_size = cpr->cp_ring_struct->ring_size;
> cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
> cmp = &cpr->cp_desc_ring[cons];
>
> --
> 2.10.1
>
>
prev parent reply other threads:[~2021-07-20 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 16:21 Kalesh A P
2021-07-20 21:35 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhu4xss_GDFnKXBdgPyTe=hrey-jwM1TUt6M3+cq1h3bHQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).