From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] net/bnxt: fix rxq interrupt setting
Date: Fri, 2 Jul 2021 14:38:20 -0700 [thread overview]
Message-ID: <CACZ4nhuNE3tWhoEcP-aaeUjS1QnuRhnSVhyk_B7uSK5QX_b=SQ@mail.gmail.com> (raw)
In-Reply-To: <20210702012415.54208-1-ajit.khaparde@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Thu, Jul 1, 2021 at 6:24 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> Don't set rxq interrupt config
> Applications can set the rxq interrupt config to 1 or 0 as needed.
> If an application is not interested in handling Rx interrupts and
> prefers to poll Rx rings, there is no need for the PMD to set this
> config option to 1.
>
> Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
> v1->v2: Setting 0 or 1 in PMD would override application setting. So skip
> it.
> ---
>
Patch applied dpdk-next-net-brcm tree, for-next-net branch.
> drivers/net/bnxt/bnxt_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 495c6cd21e..ed09f1bf52 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1011,7 +1011,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev
> *eth_dev,
> };
> eth_dev->data->dev_conf.intr_conf.lsc = 1;
>
> - eth_dev->data->dev_conf.intr_conf.rxq = 1;
> dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
> dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC;
> dev_info->tx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
> --
> 2.21.1 (Apple Git-122.3)
>
>
prev parent reply other threads:[~2021-07-02 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CACZ4nhs01rWykfOsa67-jpq1-O83ks4Y7=-GNBKdKcrzA0szkA@mail.gmail.com>
2021-07-02 1:24 ` Ajit Khaparde
2021-07-02 21:38 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhuNE3tWhoEcP-aaeUjS1QnuRhnSVhyk_B7uSK5QX_b=SQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).