From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru
Subject: Re: [PATCH 0/3] Support IPv6 flow label based RSS
Date: Thu, 8 Feb 2024 10:56:27 -0800 [thread overview]
Message-ID: <CACZ4nhuaS1304rYH+ns1sTkF=W9J0pffYADLKPNd4oUPxkLAOA@mail.gmail.com> (raw)
In-Reply-To: <f25c86ae-339a-4c57-8159-1fa1920278ff@amd.com>
[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]
On Thu, Feb 8, 2024 at 10:47 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:
>
> On 2/8/2024 5:43 AM, Ajit Khaparde wrote:
> > The use of 5-tuple of the source address, destination address,
> > source port, destination port, and the transport protocol type
> > may not be possible due to IP fragmentation, encryption, or
> > inability to parse past IPv6 extensions headers.
> >
> > Flow label values can be chosen such that they can be
> > used as part of the input to a hash function used in a load
> > distribution scheme.
> >
> > On supporting hardware, the 20-bit Flow Label field in the
> > IPv6 header can be used to perform RSS in the ingress path.
> >
> > Please apply.
> >
>
> Hi Ajit,
>
Thanks Ferruh.
> First two patch looks OK but can you please combine them into single patch?
Sure. Can do.
>
> There are two ways for RSS, config APIs and rte_flow based support,
> testpmd patch only adds flow based support, I don't know if old method
> support is required, but if you want to add you can check following sample:
> 'Commit 46914aa1c793 ("ethdev: add eCPRI RSS offload type")'
Ok. Let me check.
>
>
> Third patch, bnxt one, doesn't apply. It looks like it is on top of
> different source code, if you prefer you can make it another patch and
> get your tree.
Yes. That's right. I had used the brcm-next-net for that and wanted
to have a driver patch to show usability of the code.
I think in v2, I will just send the ethdev + testpmd patch
and add the driver patch in the PMD list/tree for cherry-pick.
Thanks
Ajit
>
>
> > Example to configure IPv6 flow label based RSS:
> >
> > flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss types ipv6-flow-label end / end
> >
> > Ajit Khaparde (3):
> > ethdev: add support for RSS based on IPv6 flow label
> > app/testpmd: add IPv6 flow label to RSS types
> > net/bnxt: add IPv6 flow label based RSS support
> >
> > app/test-pmd/config.c | 1 +
> > drivers/net/bnxt/bnxt.h | 1 +
> > drivers/net/bnxt/bnxt_ethdev.c | 2 ++
> > drivers/net/bnxt/bnxt_hwrm.c | 7 +++++++
> > drivers/net/bnxt/bnxt_vnic.c | 9 +++++++--
> > lib/ethdev/rte_ethdev.h | 1 +
> > 6 files changed, 19 insertions(+), 2 deletions(-)
> >
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
next prev parent reply other threads:[~2024-02-08 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 5:43 Ajit Khaparde
2024-02-08 5:43 ` [PATCH 1/3] ethdev: add support for RSS based on IPv6 flow label Ajit Khaparde
2024-02-08 5:43 ` [PATCH 2/3] app/testpmd: add IPv6 flow label to RSS types Ajit Khaparde
2024-02-08 5:43 ` [PATCH 3/3] net/bnxt: add IPv6 flow label based RSS support Ajit Khaparde
2024-02-08 18:47 ` [PATCH 0/3] Support IPv6 flow label based RSS Ferruh Yigit
2024-02-08 18:56 ` Ajit Khaparde [this message]
2024-02-08 21:31 ` Ferruh Yigit
2024-02-08 22:06 ` [PATCH v2] ethdev: add support for RSS based on IPv6 flow label Ajit Khaparde
2024-02-08 22:22 ` Ferruh Yigit
2024-02-08 22:24 ` Ajit Khaparde
2024-02-09 18:16 ` [PATCH v3] " Ajit Khaparde
2024-02-09 22:45 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhuaS1304rYH+ns1sTkF=W9J0pffYADLKPNd4oUPxkLAOA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).