From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Benjamin Le Berre <benjamin.le_berre@6wind.com>
Cc: somnath.kotur@broadcom.com, dev@dpdk.org, dpdk stable <stable@dpdk.org>
Subject: Re: [PATCH] net/bnxt: return -EBUSY if port is active during MTU change
Date: Mon, 3 Oct 2022 20:53:58 -0700 [thread overview]
Message-ID: <CACZ4nhuwJj0Jcmas3psviy_jv6-u-uVLqtT9N-D9O6qBnJbP7A@mail.gmail.com> (raw)
In-Reply-To: <20220915112906.4487-1-benjamin.le_berre@6wind.com>
[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]
On Thu, Sep 15, 2022 at 4:29 AM Benjamin Le Berre
<benjamin.le_berre@6wind.com> wrote:
>
> When the BNXT PMD was made to disallow MTU changes on active ports, the
> error code chosen for the case in bnxt_set_mtu_op() was -EPERM.
>
> The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h
> lists -EBUSY as the value to be used if the port must be stopped before
> applying an MTU change and does not list -EPERM as a possible return
> value.
>
> This patch makes bnxt_set_mtu_op() return -EBUSY instead of -EPERM so
> that rte_eth_dev_set_mtu() behaves as expected.
>
> Fixes: a42ab1eb33ff ("net/bnxt: disallow MTU change when device is started")
>
> Signed-off-by: Benjamin Le Berre <benjamin.le_berre@6wind.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> Hi,
>
> Should I Cc stable@dpdk.org?
I just added it to Cc. Hopefully it works.
Updated the commit headline to
net/bnxt: fix return status during MTU change
Patch merged to dpdk-next-net-brcm. Thanks
>
> Thanks,
> Benjamin.
>
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index e275d3a53fda..c07a41c693da 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3030,7 +3030,7 @@ int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
> /* Return if port is active */
> if (eth_dev->data->dev_started) {
> PMD_DRV_LOG(ERR, "Stop port before changing MTU\n");
> - return -EPERM;
> + return -EBUSY;
> }
>
> /* Exit if receive queues are not configured yet */
> --
> 2.30.2
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
parent reply other threads:[~2022-10-04 3:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220915112906.4487-1-benjamin.le_berre@6wind.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhuwJj0Jcmas3psviy_jv6-u-uVLqtT9N-D9O6qBnJbP7A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=benjamin.le_berre@6wind.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).