From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/bnxt: fix an erorr with vnic_tpa_cfg command
Date: Mon, 26 Mar 2018 13:25:02 -0700 [thread overview]
Message-ID: <CACZ4nhv2aYWFBd6T=-vW6zpZ+DtjF6o1K3e=GQPSiHHwBcJ9+Q@mail.gmail.com> (raw)
In-Reply-To: <025ed639-19b5-a4ce-f1f8-739dd9852bf2@intel.com>
On Mon, Mar 26, 2018 at 1:20 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 2/28/2018 10:12 PM, Ajit Khaparde wrote:
> > When the vnic_tpa_cfg HWRM command is sent to the FW,
> > we are not passing the VNIC ID in case of disable.
> > This can cause the FW to return an error.
> > Correct VNIC ID needs to be passed for both enable and disable.
>
> Hi Ajit,
>
> Patch title doesn't tell what is actually fixed, after reading commit log,
> will
> you be agree on following:
>
> "net/bnxt: fix LRO disable"
>
Yes, Ferruh. This is fine. Thanks
>
> >
> > Fixes: 0958d8b6435d ("net/bnxt: support LRO")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> > drivers/net/bnxt/bnxt_hwrm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> > index b7843afe6..05663fedd 100644
> > --- a/drivers/net/bnxt/bnxt_hwrm.c
> > +++ b/drivers/net/bnxt/bnxt_hwrm.c
> > @@ -1517,12 +1517,12 @@ int bnxt_hwrm_vnic_tpa_cfg(struct bnxt *bp,
> > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_GRO |
> > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_AGG_WITH_ECN
> |
> > HWRM_VNIC_TPA_CFG_INPUT_FLAGS_
> AGG_WITH_SAME_GRE_SEQ);
> > - req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
> > req.max_agg_segs = rte_cpu_to_le_16(5);
> > req.max_aggs =
> > rte_cpu_to_le_16(HWRM_VNIC_
> TPA_CFG_INPUT_MAX_AGGS_MAX);
> > req.min_agg_len = rte_cpu_to_le_32(512);
> > }
> > + req.vnic_id = rte_cpu_to_le_32(vnic->fw_vnic_id);
> >
> > rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
> >
> >
>
>
next prev parent reply other threads:[~2018-03-26 20:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 22:12 Ajit Khaparde
2018-03-26 20:20 ` Ferruh Yigit
2018-03-26 20:25 ` Ajit Khaparde [this message]
2018-03-26 20:33 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhv2aYWFBd6T=-vW6zpZ+DtjF6o1K3e=GQPSiHHwBcJ9+Q@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).