From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH] net/bnxt: restore fast-path API pointers post recovery
Date: Sun, 21 Nov 2021 21:19:58 -0800 [thread overview]
Message-ID: <CACZ4nhv6HGwC5b71Bv+dST4b_CaV3U7fkvTeNuNixg+a3mQApg@mail.gmail.com> (raw)
In-Reply-To: <20211122045314.8860-1-somnath.kotur@broadcom.com>
On Sun, Nov 21, 2021 at 8:59 PM Somnath Kotur
<somnath.kotur@broadcom.com> wrote:
>
> In bnxt_dev_recover(), restore the newly introduced fast-path API pointers
> (struct rte_eth_fp_ops)->rx_pkt_burst to the real burst routines instead of
> the dummy ones, once error recovery has successfully completed.
>
> Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure")
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Squashed with previous commit [1].
[1] https://patchwork.dpdk.org/project/dpdk/patch/20211119035041.4493-1-somnath.kotur@broadcom.com/
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index c1bdf9a921..f79f33ab4e 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -4345,6 +4345,12 @@ static void bnxt_dev_recover(void *arg)
> goto err_start;
> }
>
> + rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =
> + bp->eth_dev->rx_pkt_burst;
> + rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =
> + bp->eth_dev->tx_pkt_burst;
> + rte_mb();
> +
> rc = bnxt_restore_filters(bp);
> if (rc)
> goto err_start;
> --
> 2.28.0.497.g54e85e7
>
prev parent reply other threads:[~2021-11-22 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 4:53 Somnath Kotur
2021-11-22 5:19 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhv6HGwC5b71Bv+dST4b_CaV3U7fkvTeNuNixg+a3mQApg@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).