From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: refactor multi queue Rx configuration
Date: Sun, 2 May 2021 15:30:09 -0700 [thread overview]
Message-ID: <CACZ4nhvG4OP-AMZBgy_ZvXVY8bWEb+wN-MwLc0=SMzS_cyRHcA@mail.gmail.com> (raw)
In-Reply-To: <20210426060755.12821-1-somnath.kotur@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2569 bytes --]
On Sun, Apr 25, 2021 at 11:09 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> Eliminate separate codepath/handling for single queue
> as the multiqueue code path takes care of it as well.
> The only difference being the end_grp_id being 1
> now instead of 0 for single queue, but that does not matter
> for single queue and does not alter any functionality.
>
> Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy")
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_rxq.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
> index 2b0d3d4ac7..45e0c3d01c 100644
> --- a/drivers/net/bnxt/bnxt_rxq.c
> +++ b/drivers/net/bnxt/bnxt_rxq.c
> @@ -40,35 +40,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
>
> bp->nr_vnics = 0;
>
> - /* Single queue mode */
> - if (bp->rx_cp_nr_rings < 2) {
> - vnic = &bp->vnic_info[0];
> - if (!vnic) {
> - PMD_DRV_LOG(ERR, "VNIC alloc failed\n");
> - rc = -ENOMEM;
> - goto err_out;
> - }
> - vnic->flags |= BNXT_VNIC_INFO_BCAST;
> - bp->nr_vnics++;
> -
> - rxq = bp->eth_dev->data->rx_queues[0];
> - rxq->vnic = vnic;
> -
> - vnic->func_default = true;
> - vnic->start_grp_id = 0;
> - vnic->end_grp_id = vnic->start_grp_id;
> - filter = bnxt_alloc_filter(bp);
> - if (!filter) {
> - PMD_DRV_LOG(ERR, "L2 filter alloc failed\n");
> - rc = -ENOMEM;
> - goto err_out;
> - }
> - filter->mac_index = 0;
> - filter->flags |=
> HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST;
> - STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
> - goto out;
> - }
> -
> /* Multi-queue mode */
> if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) {
> /* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */
> @@ -163,7 +134,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp)
> end_grp_id += nb_q_per_grp;
> }
>
> -out:
> bp->rx_num_qs_per_vnic = nb_q_per_grp;
>
> if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) {
> --
> 2.28.0.497.g54e85e7
>
>
prev parent reply other threads:[~2021-05-02 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 6:07 Somnath Kotur
2021-04-26 6:07 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix Rx FIFO pending bit Somnath Kotur
2021-05-02 22:31 ` Ajit Khaparde
2021-05-02 22:30 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhvG4OP-AMZBgy_ZvXVY8bWEb+wN-MwLc0=SMzS_cyRHcA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).