From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/bnxt: fix Rx checksum flags
Date: Tue, 6 Feb 2018 15:27:01 -0800 [thread overview]
Message-ID: <CACZ4nhvZ3JH=z8kd2suJUUDcwPj19zWAbUnDhxQPMLcOxLXPGg@mail.gmail.com> (raw)
In-Reply-To: <20180206133931.23991-1-olivier.matz@6wind.com>
On Tue, Feb 6, 2018 at 5:39 AM, Olivier Matz <olivier.matz@6wind.com> wrote:
> Fix the Rx offload flags when the IP or L4 checksum is seen as incorrect
> by the hardware. In this case, the proper value is PKT_RX_IP_CKSUM_BAD.
>
> PKT_RX_IP_CKSUM_NONE means that the checksum may be incorrect in the
> packet headers, but the integrity of the IP header is verified. This is
> mostly useful for virtual drivers.
>
> Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>
> Hi Ajit,
>
> PKT_RX_IP_CKSUM_UNKNOWN is also a good candidate instead of
> PKT_RX_IP_CKSUM_BAD. Please can you check?
>
Thanks Oliver. Sure. I will take a look.
Ajit
>
> Thanks
> Olivier
>
>
>
> drivers/net/bnxt/bnxt_rxr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 9e70c8604..9b88a64bf 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -475,12 +475,12 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
> if (likely(RX_CMP_IP_CS_OK(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> else
> - mbuf->ol_flags |= PKT_RX_IP_CKSUM_NONE;
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
>
> if (likely(RX_CMP_L4_CS_OK(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
> else
> - mbuf->ol_flags |= PKT_RX_L4_CKSUM_NONE;
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
>
> mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
>
> --
> 2.11.0
>
>
next prev parent reply other threads:[~2018-02-06 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 13:39 Olivier Matz
2018-02-06 23:27 ` Ajit Khaparde [this message]
2018-02-08 13:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhvZ3JH=z8kd2suJUUDcwPj19zWAbUnDhxQPMLcOxLXPGg@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).