From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx
Date: Thu, 14 Nov 2019 21:24:23 -0800 [thread overview]
Message-ID: <CACZ4nhvntRxoRqVM5WEdpGygpUcD9tXD18y65QBMyeLfrOHU1A@mail.gmail.com> (raw)
In-Reply-To: <20191115045028.11319-1-somnath.kotur@broadcom.com>
On Thu, Nov 14, 2019 at 8:58 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors
> for both tunneled and non-tunneled IP packets.
>
> Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector
> Rx")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_rxr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index c35bc1afd..3b713c242 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -515,16 +515,18 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,
> if (likely(IS_IP_NONTUNNEL_PKT(flags2_f))) {
> if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> else
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> } else if (IS_IP_TUNNEL_PKT(flags2_f)) {
> if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) ||
> RX_CMP_IP_CS_ERROR(rxcmp1)))
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> else
> mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> - } else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) {
> - mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> }
>
> /* L4 Checksum */
> --
> 2.23.0.rc1
>
>
prev parent reply other threads:[~2019-11-15 5:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 4:50 Somnath Kotur
2019-11-15 5:24 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhvntRxoRqVM5WEdpGygpUcD9tXD18y65QBMyeLfrOHU1A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).