From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dev@dpdk.org, ferruh.yigit@xilinx.com
Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: remove unnecessary check
Date: Mon, 3 Oct 2022 20:58:26 -0700 [thread overview]
Message-ID: <CACZ4nhvxHveJBe5AEBBq3dpoVK+qNoJ=1jF6oV7RANrddBujpw@mail.gmail.com> (raw)
In-Reply-To: <20220927155902.29850-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
On Tue, Sep 27, 2022 at 9:00 AM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> We are not invoking rte_eth_switch_domain_free currently owing to
> an unnecessary check. This patch fixes that.
>
> Fixes: e2895305a5b5 ("net/bnxt: fix resource cleanup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index e275d3a..84cf9a3 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -5977,8 +5977,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool reconfig_dev)
> bnxt_uninit_ctx_mem(bp);
>
> bnxt_free_flow_stats_info(bp);
> - if (bp->rep_info != NULL)
> - bnxt_free_switch_domain(bp);
> + bnxt_free_switch_domain(bp);
> bnxt_free_rep_info(bp);
> rte_free(bp->ptp_cfg);
> bp->ptp_cfg = NULL;
> --
> 2.10.1
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
prev parent reply other threads:[~2022-10-04 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 15:59 Kalesh A P
2022-09-27 15:59 ` [dpdk-dev] [PATCH 2/2] net/bnxt: fix freeing of representor info memory Kalesh A P
2022-10-04 3:59 ` Ajit Khaparde
2022-10-04 3:58 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhvxHveJBe5AEBBq3dpoVK+qNoJ=1jF6oV7RANrddBujpw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).