From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised
Date: Tue, 20 Dec 2016 11:02:53 +0000 [thread overview]
Message-ID: <CAD+H9902ihUh-a=z2_ShUnxK_A+uPSjasBYwAbMjxkVO_-OSzA@mail.gmail.com> (raw)
In-Reply-To: <CAD+H992=T2bgGiNhC-Lcir8a8pjdwpd1icvtJVif1_oZv4Q_sw@mail.gmail.com>
On Tue, Dec 20, 2016 at 10:29 AM, Alejandro Lucero <
alejandro.lucero@netronome.com> wrote:
>
>
> On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
>
>> On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
>> > I forgot one thing: to update the features file with this new one.
>> >
>> > I will wait for your feedback regarding the discussed problem for
>> > sending another version.
>>
>> I think it is good to go, please send updated version.
>>
>>
> OK
>
>
>> >
>>
>> <...>
>>
>> >
>> > Sorry, confused. Is it like following:
>> >
>> > "
>> > For new FW, there is no problem, it supports the range between
>> > 1G - 50G,
>> > and reports correct current speed.
>> >
>> > With old FW, device still can be set to speed range between 1G -
>> > 50G,
>> > but it doesn't report current speed correct, and DPDK driver
>> reports
>> > back to application as device current speed is 40G, without
>> really
>> > knowing the current speed.
>> > "
>> >
>> >
>> > Yes, that is. Should then I do anything else or the patch is right
>> > for you now?
>>
>> So, this patch is correct.
>>
>> But for the previous patch "net/nfp: report link speed using hardware
>> info", it would be nice to add above information into source as comment
>> and into commit log.
>> If you can, would you mind sending a new version of that patch?
>>
>>
>
Would it be better to report ETH_SPEED_NUM_NONE instead of
ETH_SPEED_NUM_40G for old firmware?
I will add a comment about why, but I think this is better for the user not
getting (sometimes) the right speed.
> I'll do it.
>
> Thanks!
>
>
>> Thanks,
>> ferruh
>>
>> >
>> <...>
>>
>
>
prev parent reply other threads:[~2016-12-20 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 12:05 Alejandro Lucero
2016-12-19 14:36 ` Ferruh Yigit
2016-12-19 15:02 ` Alejandro Lucero
2016-12-19 15:05 ` Ferruh Yigit
2016-12-19 16:18 ` Alejandro Lucero
2016-12-19 16:35 ` Marc
2016-12-19 17:58 ` Alejandro Lucero
2016-12-19 16:43 ` Ferruh Yigit
2016-12-19 17:59 ` Alejandro Lucero
2016-12-19 18:00 ` Alejandro Lucero
2016-12-20 10:25 ` Ferruh Yigit
2016-12-20 10:29 ` Alejandro Lucero
2016-12-20 11:02 ` Alejandro Lucero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H9902ihUh-a=z2_ShUnxK_A+uPSjasBYwAbMjxkVO_-OSzA@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).