From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: dev <dev@dpdk.org>,
stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3 1/6] mem: add function for checking memsegs IOVAs addresses
Date: Tue, 10 Jul 2018 11:52:01 +0100 [thread overview]
Message-ID: <CAD+H990_U86tXG4XrbBzPF3OSS6XC6CfWaA9KzRYkVYX0ZJvCg@mail.gmail.com> (raw)
In-Reply-To: <DEAB907C-0662-48E6-975D-06075BE3D4CC@redhat.com>
On Tue, Jul 10, 2018 at 11:06 AM, Eelco Chaudron <echaudro@redhat.com>
wrote:
>
>
> On 10 Jul 2018, at 11:34, Alejandro Lucero wrote:
>
> On Tue, Jul 10, 2018 at 9:56 AM, Eelco Chaudron <echaudro@redhat.com>
>> wrote:
>>
>>
>>>
>>> On 4 Jul 2018, at 14:53, Alejandro Lucero wrote:
>>>
>>> A device can suffer addressing limitations. This functions checks
>>>
>>>> memsegs have iovas within the supported range based on dma mask.
>>>>
>>>> PMD should use this during initialization if supported devices
>>>> suffer addressing limitations, returning an error if this function
>>>> returns memsegs out of range.
>>>>
>>>> Another potential usage is for emulated IOMMU hardware with addressing
>>>> limitations.
>>>>
>>>> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>>>> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>>> ---
>>>> lib/librte_eal/common/eal_common_memory.c | 33
>>>> ++++++++++++++++++++++++++++++
>>>> lib/librte_eal/common/include/rte_memory.h | 3 +++
>>>> lib/librte_eal/rte_eal_version.map | 1 +
>>>> 3 files changed, 37 insertions(+)
>>>>
>>>> diff --git a/lib/librte_eal/common/eal_common_memory.c
>>>> b/lib/librte_eal/common/eal_common_memory.c
>>>> index fc6c44d..f5efebe 100644
>>>> --- a/lib/librte_eal/common/eal_common_memory.c
>>>> +++ b/lib/librte_eal/common/eal_common_memory.c
>>>> @@ -109,6 +109,39 @@
>>>> }
>>>> }
>>>>
>>>> +/* check memseg iovas are within the required range based on dma mask
>>>> */
>>>> +int
>>>> +rte_eal_check_dma_mask(uint8_t maskbits)
>>>> +{
>>>> +
>>>> + const struct rte_mem_config *mcfg;
>>>> + uint64_t mask;
>>>> + int i;
>>>> +
>>>>
>>>>
>>> I think we should add some sanity check to the input maskbits, i.e.
>>> [64,0)
>>> or [64, 32]? What would be a reasonable lower bound.
>>>
>>>
>>> This is not a user's API, so any invocation will be reviewed, but I guess
>> adding a sanity check here does not harm.
>>
>> Not sure about lower bound but upper should 64, although it does not make
>> sense but it is safe. Lower bound is not so problematic.
>>
>>
>>
>>> + /* create dma mask */
>>>
>>>> + mask = ~((1ULL << maskbits) - 1);
>>>> +
>>>> + /* get pointer to global configuration */
>>>> + mcfg = rte_eal_get_configuration()->mem_config;
>>>> +
>>>> + for (i = 0; i < RTE_MAX_MEMSEG; i++) {
>>>> + if (mcfg->memseg[i].addr == NULL)
>>>> + break;
>>>>
>>>
> Looking at some other code, it looks like NULL entries might exists. So
> should a continue; rather than a break; be used here?
>
>
I do not think so. memsegs are allocated sequentially, so first with addr
as NULL implies no more memsegs.
>
> +
>>>> + if (mcfg->memseg[i].iova & mask) {
>>>> + RTE_LOG(INFO, EAL,
>>>> + "memseg[%d] iova %"PRIx64" out of
>>>> range:\n",
>>>> + i, mcfg->memseg[i].iova);
>>>> +
>>>> + RTE_LOG(INFO, EAL, "\tusing dma mask
>>>> %"PRIx64"\n",
>>>> + mask);
>>>> + return -1;
>>>> + }
>>>> + }
>>>> +
>>>> + return 0;
>>>> +}
>>>> +
>>>> /* return the number of memory channels */
>>>> unsigned rte_memory_get_nchannel(void)
>>>> {
>>>> diff --git a/lib/librte_eal/common/include/rte_memory.h
>>>> b/lib/librte_eal/common/include/rte_memory.h
>>>> index 80a8fc0..b2a0168 100644
>>>> --- a/lib/librte_eal/common/include/rte_memory.h
>>>> +++ b/lib/librte_eal/common/include/rte_memory.h
>>>> @@ -209,6 +209,9 @@ struct rte_memseg {
>>>> */
>>>> unsigned rte_memory_get_nrank(void);
>>>>
>>>> +/* check memsegs iovas are within a range based on dma mask */
>>>> +int rte_eal_check_dma_mask(uint8_t maskbits);
>>>> +
>>>> /**
>>>> * Drivers based on uio will not load unless physical
>>>> * addresses are obtainable. It is only possible to get
>>>> diff --git a/lib/librte_eal/rte_eal_version.map
>>>> b/lib/librte_eal/rte_eal_version.map
>>>> index f4f46c1..aa6cf87 100644
>>>> --- a/lib/librte_eal/rte_eal_version.map
>>>> +++ b/lib/librte_eal/rte_eal_version.map
>>>> @@ -184,6 +184,7 @@ DPDK_17.11 {
>>>>
>>>> rte_eal_create_uio_dev;
>>>> rte_bus_get_iommu_class;
>>>> + rte_eal_check_dma_mask;
>>>> rte_eal_has_pci;
>>>> rte_eal_iova_mode;
>>>> rte_eal_mbuf_default_mempool_ops;
>>>> --
>>>> 1.9.1
>>>>
>>>>
>>>
>
>
next prev parent reply other threads:[~2018-07-10 10:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 12:53 [dpdk-stable] [PATCH v3 0/6] use IOVAs check based on DMA mask Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 1/6] mem: add function for checking memsegs IOVAs addresses Alejandro Lucero
2018-07-10 8:56 ` Eelco Chaudron
2018-07-10 9:34 ` Alejandro Lucero
2018-07-10 10:06 ` Eelco Chaudron
2018-07-10 10:52 ` Alejandro Lucero [this message]
2018-07-10 11:14 ` Eelco Chaudron
2018-07-10 11:33 ` Burakov, Anatoly
2018-07-10 11:43 ` Alejandro Lucero
2018-07-10 11:55 ` Eelco Chaudron
2018-07-10 11:40 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 2/6] ethdev: add function for checking IOVAs by a device Alejandro Lucero
2018-07-07 17:30 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2018-07-10 8:57 ` [dpdk-stable] " Eelco Chaudron
2018-07-10 9:42 ` Alejandro Lucero
2018-07-10 9:44 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 3/6] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-07-10 10:14 ` Eelco Chaudron
2018-07-10 15:37 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 4/6] mem: use address hint for mapping hugepages Alejandro Lucero
2018-07-10 11:15 ` Eelco Chaudron
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 5/6] net/nfp: check hugepages IOVAs based on DMA mask Alejandro Lucero
2018-07-10 10:17 ` Eelco Chaudron
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 6/6] net/nfp: support IOVA VA mode Alejandro Lucero
2018-07-10 10:18 ` Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+H990_U86tXG4XrbBzPF3OSS6XC6CfWaA9KzRYkVYX0ZJvCg@mail.gmail.com \
--to=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).