From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 17.11] mem: fix memory initialization time
Date: Fri, 16 Nov 2018 12:49:43 +0000 [thread overview]
Message-ID: <CAD+H99164jhE6k+DQQ-=2rTBpkRB_GMV1pzdR1x2Y0TUGSzqCw@mail.gmail.com> (raw)
In-Reply-To: <dea81690-abe7-09f3-9ceb-9047af299c7c@intel.com>
On Thu, Nov 15, 2018 at 1:16 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> On 12-Nov-18 11:18 AM, Alejandro Lucero wrote:
> > When using large amount of hugepage based memory, doing all the
> > hugepages mapping can take quite significant time.
> >
> > The problem is hugepages being initially mmaped to virtual addresses
> > which will be tried later for the final hugepage mmaping. This causes
> > the final mapping requiring calling mmap with another hint address which
> > can happen several times, depending on the amount of memory to mmap, and
> > which each mmmap taking more than a second.
> >
> > This patch changes the hint for the initial hugepage mmaping using
> > a starting address which will not collide with the final mmaping.
> >
> > Fixes: 293c0c4b957f ("mem: use address hint for mapping hugepages")
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
>
> Hi Alejandro,
>
> I'm not sure i understand the purpose. When final mapping is performed,
> we reserve new memory area, and map pages into it. (i don't quite
> understand why we unmap the area before mapping pages, but it's how it's
> always been and i didn't change it in the legacy code)
>
> Which addresses are causing the collision?
>
>
Because the hint for the final mapping is at 4GB address, and the hugepages
are initially individually mapped starting at low virtual addresses, when
the memory to map is 4GB or higher, the hugepages will end using that hint
address and higher. The more the hugepages to mmap, the more addresses
above the hint address are used, and the more mmaps failed for getting the
virtual addresses for the final mmap.
> --
> Thanks,
> Anatoly
>
next prev parent reply other threads:[~2018-11-16 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 11:18 [dpdk-stable] " Alejandro Lucero
2018-11-12 11:26 ` Eelco Chaudron
2018-11-14 12:45 ` [dpdk-stable] [dpdk-dev] " Eelco Chaudron
2018-11-15 13:16 ` Burakov, Anatoly
2018-11-16 12:49 ` Alejandro Lucero [this message]
2018-11-16 13:35 ` Burakov, Anatoly
2018-11-16 14:42 ` Alejandro Lucero
2018-11-16 15:56 ` Burakov, Anatoly
2018-11-28 23:04 ` [dpdk-stable] " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H99164jhE6k+DQQ-=2rTBpkRB_GMV1pzdR1x2Y0TUGSzqCw@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).