From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info
Date: Fri, 18 Nov 2016 15:42:18 +0000 [thread overview]
Message-ID: <CAD+H991be_HVRD83=OEZ3vCPpVSkjQ-KmpE958UWB-+o_tDycQ@mail.gmail.com> (raw)
In-Reply-To: <CAD+H992NtFefKXxNQiJng7i+6AtJywSSuLCaU4D-TBw_Svj17g@mail.gmail.com>
On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero <
alejandro.lucero@netronome.com> wrote:
>
>
> On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
>
>> On 11/18/2016 3:10 PM, Alejandro Lucero wrote:
>> > Hi Thomas,
>> >
>> > I got this email when sending a patch some minutes ago.
>> >
>> > The point is I trusted script/checkpatches.sh which did not report those
>> > warnings.
>> > Am I doing anything wrong when using checkpatches.sh?
>>
>> I am also getting same warnings as below, this can be related to the
>> checkpatch.pl version.
>>
>> I have: Version: 0.32
>> (./scripts/checkpatch.pl --version)
>>
>>
> Uhmm, I got same one.
>
>
Ok. It seems I suffered a temporal blindness. I though the automatic report
was about warnings but it is about checks. But I got just one of the checks
messages. This is the output with -v and adding OPTIONS used:
### [PATCH] nfp: report link speed using hardware info
OPTIONS: --no-tree --max-line-length=80 --show-types
--ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,NEW_TYPEDEFS,COMPARISON_TO_NULL
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#60: FILE: drivers/net/nfp/nfp_net.c:856:
+ else {
+
total: 0 errors, 0 warnings, 1 checks, 68 lines checked
0/1 valid patch
> >
>> >
>> > ---------- Forwarded message ----------
>> > From: <checkpatch@dpdk.org>
>> > Date: Fri, Nov 18, 2016 at 3:04 PM
>> > Subject: |WARNING| [PATCH] nfp: report link speed using hardware info
>> > To: test-report@dpdk.org
>> > Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
>> >
>> >
>> > Test-Label: checkpatch
>> > Test-Status: WARNING
>> > http://dpdk.org/patch/17091
>> >
>> > _coding style issues_
>> >
>> >
>> > CHECK:MACRO_ARG_REUSE: Macro argument reuse 'arr' - possible
>> side-effects?
>> > #53: FILE: drivers/net/nfp/nfp_net.c:806:
>> > +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
>> >
>> > CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
>> > #91: FILE: drivers/net/nfp/nfp_net.c:856:
>> > + else {
>> > +
>> >
>> > total: 0 errors, 0 warnings, 2 checks, 68 lines checked
>> >
>>
>>
>
next prev parent reply other threads:[~2016-11-18 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 15:04 [dpdk-dev] " Alejandro Lucero
[not found] ` <20161118150433.AD575558B@dpdk.org>
2016-11-18 15:10 ` [dpdk-dev] Fwd: |WARNING| " Alejandro Lucero
2016-11-18 15:24 ` Ferruh Yigit
2016-11-18 15:31 ` Alejandro Lucero
2016-11-18 15:42 ` Alejandro Lucero [this message]
2016-11-18 15:44 ` Thomas Monjalon
2016-11-18 15:34 ` Thomas Monjalon
2016-11-18 15:26 ` Ferruh Yigit
2016-11-18 15:33 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H991be_HVRD83=OEZ3vCPpVSkjQ-KmpE958UWB-+o_tDycQ@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).