From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/2] support MAC changes when no live changes allowed
Date: Thu, 23 Aug 2018 11:22:58 +0200 [thread overview]
Message-ID: <CAD+H991iz778j+ckAPiw4waN-0QZhN6sfvwpduqywH-Mz+dBHA@mail.gmail.com> (raw)
In-Reply-To: <6a63d8a4-f51d-b266-9877-73775145b52f@intel.com>
On Wed, Aug 22, 2018 at 6:00 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 7/18/2018 9:58 AM, Ferruh Yigit wrote:
> > On 7/9/2018 6:14 PM, Alejandro Lucero wrote:
> >> This is a patched to fix a functionality coming with the first public
> >> release: changing/setting MAC address.
> >>
> >> The original patch assumes all NICs can safely change or set the MAC
> >> in any case. However, this is not always true. NFP depends on the
> firmware
> >> capabilities and this is not always supported. There are other NICs with
> >> this same limitation, although, as far as I know, not in DPDK. Linux
> kernel
> >> has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for
> >> allowing or not live MAC changes.
> >>
> >> The flag proposed in this patch is just the opposite: advertise if live
> >> change not supported and assuming it is supported other way.
> >>
> >> Although most NICs support rte_eth_dev_default_mac_addr_set and this
> >> function returns and error when live change is not supported, note that
> >> this function is invoked during port start but the value returned is not
> >> checked. It is likely this is good enough for most of the cases, but
> >> bonding is relying on this start then mac set/change, and a PMD ports is
> >> not properly configured for being used as an slave port in some bonding
> >> modes.
> >
> > Hi Alejandro,
> >
> > Overall looks good to me, only it can be good to update
> "rte_eth_dev_start" API
> > doc to mention about affect of new flag and perhaps update release notes
> "API
> > Changes" section to document behavior change of the "rte_eth_dev_start"
> API
> > based on flag.
>
> Would you mind sending a new version for this release, v18.11, with above
> documentation update?
>
>
Sure. I have been on a large PTO break but I planned to send this asap.
Thanks
> Thanks,
> ferruh
>
> >
> > But, the ethdev library patch was late for this release, I suggest
> considering
> > the patch for next release, meanwhile it can get more reviews.
> >
> > Thanks,
> > ferruh
> >
>
>
prev parent reply other threads:[~2018-08-23 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 17:14 [dpdk-stable] " Alejandro Lucero
2018-07-09 17:14 ` [dpdk-stable] [PATCH 1/2] ethdev: fix MAC changes when live change not supported Alejandro Lucero
2018-07-09 17:14 ` [dpdk-stable] [PATCH 2/2] net/nfp: fix live MAC changes " Alejandro Lucero
2018-07-18 8:58 ` [dpdk-stable] [PATCH 0/2] support MAC changes when no live changes allowed Ferruh Yigit
2018-08-22 16:00 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2018-08-23 9:22 ` Alejandro Lucero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+H991iz778j+ckAPiw4waN-0QZhN6sfvwpduqywH-Mz+dBHA@mail.gmail.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).