From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/5] net/nfp logging fixes
Date: Thu, 26 Apr 2018 13:52:53 +0100 [thread overview]
Message-ID: <CAD+H992-ax+N2H4oEA7vF_FOiK7w7+X1pZ7S7PA2kt+FyCb-6g@mail.gmail.com> (raw)
In-Reply-To: <20180425154551.6795-1-stephen@networkplumber.org>
Hi Stephen,
Thanks for this patch set.
I'm happy with it although I have some concerns regarding how the dynamic
logs work, or maybe I have a wrong understanding about it. I have tried to
read some doc about how it works, and I found the original patch from
Olivier the best source, so maybe things have changed a bit and my concerns
are unfounded.
I think it is OK to specifically add something like
--log-level='pmd\.i40e.*,8'
if you want to debug a PMD, but if you are an user and you just want to
know why the app is not finding any port, finding out the right string is
not trivial. For example, with an PF, the NFP PMD goes through a process
where the NFP device (no the NIC) is accessed first through a complex
interface, then firmware is uploaded, DPDK ports created (for multiport
devices), etc. I think any error in that process should be output if the
right loglevel is there and not just if the right log type was specifically
enabled. Is this what would happen with your patchset?
I have suffered silent configuration problems, like the NFP card being in
the wrong NUMA socket, and although I can solve that quickly because I have
the knowledge, other people using NFP with DPDK require someone to help
because they do not know what is going on. And this is usually bad because
they have another NIC card in the same host (in the right NUMA socket) and
the app just works smoothly then, leaving our NIC with a bad press. So I
think, some errors should always appear with the right loglevel configured.
On Wed, Apr 25, 2018 at 4:45 PM, Stephen Hemminger <
stephen@networkplumber.org> wrote:
> These are several small changes to make the Netronome driver
> use logging macros in the same way as other drivers.
>
> Compile tested only. I don't have Netronome hardware.
>
> Stephen Hemminger (5):
> net/nfp: use correct logtype for init messages
> net/nfp: add implied new line to PMD_DRV_LOG
> net/nfp: fix double space in init log
> net/nfl: add newline in PMD_RX/TX_LOG macros
> net/nfp: use dynamic logging everywhere
>
> drivers/net/nfp/nfp_net.c | 186 ++++++++++++++++-----------------
> drivers/net/nfp/nfp_net_logs.h | 9 +-
> 2 files changed, 98 insertions(+), 97 deletions(-)
>
> --
> 2.17.0
>
>
next prev parent reply other threads:[~2018-04-26 12:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 15:45 Stephen Hemminger
2018-04-25 15:45 ` [dpdk-dev] [PATCH 1/5] net/nfp: use correct logtype for init messages Stephen Hemminger
2018-04-25 15:45 ` [dpdk-dev] [PATCH 2/5] net/nfp: add implied new line to PMD_DRV_LOG Stephen Hemminger
2018-04-25 15:45 ` [dpdk-dev] [PATCH 3/5] net/nfp: fix double space in init log Stephen Hemminger
2018-04-25 15:45 ` [dpdk-dev] [PATCH 4/5] net/nfl: add newline in PMD_RX/TX_LOG macros Stephen Hemminger
2018-04-25 15:45 ` [dpdk-dev] [PATCH 5/5] net/nfp: use dynamic logging everywhere Stephen Hemminger
2018-04-26 12:52 ` Alejandro Lucero [this message]
2018-04-26 15:42 ` [dpdk-dev] [PATCH 0/5] net/nfp logging fixes Stephen Hemminger
2018-04-26 18:14 ` Alejandro Lucero
2018-04-26 21:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+H992-ax+N2H4oEA7vF_FOiK7w7+X1pZ7S7PA2kt+FyCb-6g@mail.gmail.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).