From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/nfp: fix Vlan offload flags check
Date: Fri, 13 Jan 2017 11:36:57 +0000 [thread overview]
Message-ID: <CAD+H992nO=wxzLtS_Dkchmqk4azYYLBh73iUZuHNBQVGGAqdvg@mail.gmail.com> (raw)
In-Reply-To: <1484226296-540-1-git-send-email-olivier.matz@6wind.com>
Acked.
Thanks!
On Thu, Jan 12, 2017 at 1:04 PM, Olivier Matz <olivier.matz@6wind.com>
wrote:
> Fix typo when checking that no Vlan offload flags are passed at port
> initialization.
>
> By the way, also fix a typo in the log.
>
> Fixes: d4a27a3b092a ("nfp: add basic features")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> drivers/net/nfp/nfp_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 65ba09f..ed3c9b8 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -2174,8 +2174,8 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev,
> int mask)
> new_ctrl = 0;
>
> if ((mask & ETH_VLAN_FILTER_OFFLOAD) ||
> - (mask & ETH_VLAN_FILTER_OFFLOAD))
> - RTE_LOG(INFO, PMD, "Not support for
> ETH_VLAN_FILTER_OFFLOAD or"
> + (mask & ETH_VLAN_FILTER_EXTEND))
> + RTE_LOG(INFO, PMD, "No support for ETH_VLAN_FILTER_OFFLOAD
> or"
> " ETH_VLAN_FILTER_EXTEND");
>
> /* Enable vlan strip if it is not configured yet */
> --
> 2.8.1
>
>
next prev parent reply other threads:[~2017-01-13 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:04 Olivier Matz
2017-01-13 11:36 ` Alejandro Lucero [this message]
2017-01-13 12:03 ` Ferruh Yigit
2017-01-13 12:48 ` Olivier Matz
2017-01-13 13:17 ` Ferruh Yigit
2017-01-13 14:48 ` Olivier Matz
2017-01-13 14:57 ` Alejandro Lucero
2017-01-13 15:16 ` [dpdk-dev] [PATCH] net/nfp: fix VLAN " Ferruh Yigit
2017-01-13 15:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H992nO=wxzLtS_Dkchmqk4azYYLBh73iUZuHNBQVGGAqdvg@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).