From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/nfp: fix unused header reference
Date: Mon, 11 Jun 2018 09:35:47 +0100 [thread overview]
Message-ID: <CAD+H993OL-8Be88jydKuj5-F_wtiB0RUREsv-tXRT4pP45VZzA@mail.gmail.com> (raw)
In-Reply-To: <db55dc0d-1a59-f3f5-ffd4-2834f5a65487@intel.com>
Sure. I will send another version adding that syntax.
Thanks
On Fri, Jun 8, 2018 at 8:49 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 6/8/2018 11:40 AM, Alejandro Lucero wrote:
> > Apart from not being used, this is causing problem when compiling
> > DPDK with the musl library as reported by bugzilla.
>
> If this is fixing a bugzilla issue, can you please use defined syntax to
> document it:
>
> Bugzilla ID: ###
> Fixes: ############ ("....")
> Cc: stable@dpdk.org --> [optional if needs to go in stable tree]
>
> >
> > Fixes: c7e9729da6b5 ("net/nfp: support CPP")
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> > drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > index b8541c5..d46574b 100644
> > --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > @@ -13,7 +13,6 @@
> > #include <stdlib.h>
> > #include <ctype.h>
> > #include <inttypes.h>
> > -#include <sys/cdefs.h>
> > #include <sys/stat.h>
> > #include <limits.h>
> > #include <errno.h>
> >
>
>
next prev parent reply other threads:[~2018-06-11 8:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 10:40 Alejandro Lucero
2018-06-08 19:49 ` Ferruh Yigit
2018-06-11 8:35 ` Alejandro Lucero [this message]
2018-06-11 9:55 Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+H993OL-8Be88jydKuj5-F_wtiB0RUREsv-tXRT4pP45VZzA@mail.gmail.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).