From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 06/16] nfp: add nsp symbol resolution command
Date: Thu, 31 Aug 2017 10:35:34 +0100 [thread overview]
Message-ID: <CAD+H993c=ZHU_nvf4j0aD8dpM+4V6u9Fszj8_5kb1E1TL02Gaw@mail.gmail.com> (raw)
In-Reply-To: <10ad2437-d665-5c42-ec61-2cf830f2f92e@intel.com>
On Mon, Aug 28, 2017 at 5:42 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 8/24/2017 5:20 PM, Alejandro Lucero wrote:
> > Firmware has symbols helping to configure things like number of
> > PF ports, vNIC BARs addresses inside NFP memories, or ethernet
> > link state. Different firmware apps have different things to map
> > and likely different internal NFP addresses to use.
> >
> > Host drivers can use the NSPU interface for getting symbol data
> > regarding different hardware configurations. Once the driver has
> > the information about a specific object, a mapping is required
> > configuring an NFP expansion bar creating a device PCI bar window.
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
> <...>
>
> > +
> > + /* Adjusting address based on symbol location */
> > + if (domain >= 24 && domain << 28 && target == 7) {
>
> gcc is giving following compiler warning [1]. Most probably intention is
> the compare, but it is not clear, can you please check?
>
I have not seen this warning but I will add parenthesis for avoiding
ambiguity.
Thanks
>
> [1]
> .../drivers/net/nfp/nfp_nspu.c: In function ‘nfp_nspu_set_bar_from_symbl’:
> .../drivers/net/nfp/nfp_nspu.c:446:29: error: ‘<<’ in boolean context,
> did you mean ‘<’ ? [-Werror=int-in-bool-context]
> if (domain >= 24 && domain << 28 && target == 7) {
> ~~~~~~~^~~~~
>
> > + addr = 1ULL << 37 | addr | ((uint64_t)domain & 0x3) << 35;
> > + } else {
> > + addr = 1ULL << 39 | addr | ((uint64_t)domain & 0x3f) << 32;
> > + if (target == -7)
> > + target = 7;
> > + }
>
next prev parent reply other threads:[~2017-08-31 9:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 16:20 [dpdk-dev] [PATCH 00/16] nfp: add pf support Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 01/16] nfp: add nsp user space interface Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 02/16] nfp: add specific pf probe function Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:23 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 03/16] nfp: add support for new pci id Alejandro Lucero
2017-08-28 16:43 ` Ferruh Yigit
2017-08-31 9:08 ` Alejandro Lucero
2017-08-31 9:13 ` Ferruh Yigit
2017-08-31 9:24 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 04/16] nfp: add nsp support for commands Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 05/16] nfp: add nsp fw upload command Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:04 ` Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 06/16] nfp: add nsp symbol resolution command Alejandro Lucero
2017-08-28 16:42 ` Ferruh Yigit
2017-08-31 9:35 ` Alejandro Lucero [this message]
2017-08-24 16:20 ` [dpdk-dev] [PATCH 07/16] nfp: add fw upload logic Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 08/16] nfp: add support for vnic config bar mapping Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 09/16] nfp: add support for vNIC rx/tx bar mappings Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 10/16] nfp: support pf devices inside pmd initialization Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 11/16] nfp: allocate eth_dev from pf probe function Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 12/16] nfp: support pf multiport Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 13/16] nfp: add nsp support for hw link configuration Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 14/16] nfp: add support for hw port " Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 15/16] nfp: read pf port mac addr using nsp Alejandro Lucero
2017-08-24 16:20 ` [dpdk-dev] [PATCH 16/16] doc: update nfp with pf support information Alejandro Lucero
2017-08-28 16:42 ` [dpdk-dev] [PATCH 00/16] nfp: add pf support Ferruh Yigit
2017-08-31 9:00 ` Alejandro Lucero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H993c=ZHU_nvf4j0aD8dpM+4V6u9Fszj8_5kb1E1TL02Gaw@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).