From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode
Date: Thu, 4 Oct 2018 18:59:14 +0100 [thread overview]
Message-ID: <CAD+H993ni8ucU88pD1qi-kGSF3yzQAv7RiUp_i2n0vMOkPhxKQ@mail.gmail.com> (raw)
In-Reply-To: <b527fe6e-db8a-900e-46b9-31022e696a79@intel.com>
On Thu, Oct 4, 2018 at 4:49 PM Burakov, Anatoly <anatoly.burakov@intel.com>
wrote:
> On 04-Oct-18 2:35 PM, Alejandro Lucero wrote:
> >
> >
> > On Wed, Oct 3, 2018 at 1:56 PM Burakov, Anatoly
> > <anatoly.burakov@intel.com <mailto:anatoly.burakov@intel.com>> wrote:
> >
> > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote:
> > > Although VT-d emulation currently only supports 39 bits, it could
> > > be iovas being within that supported range. This patch allows
> > > IOVA mode in such a case.
> > >
> > > Indeed, memory initialization code can be modified for using lower
> > > virtual addresses than those used by the kernel for 64 bits
> processes
> > > by default, and therefore memsegs iovas can use 39 bits or less
> for
> > > most system. And this is likely 100% true for VMs.
> > >
> > > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com
> > <mailto:alejandro.lucero@netronome.com>>
> > > ---
> > > drivers/bus/pci/linux/pci.c | 15 ++++++++++-----
> > > 1 file changed, 10 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/bus/pci/linux/pci.c
> > b/drivers/bus/pci/linux/pci.c
> > > index 04648ac..215dc10 100644
> > > --- a/drivers/bus/pci/linux/pci.c
> > > +++ b/drivers/bus/pci/linux/pci.c
> > > @@ -588,10 +588,11 @@
> > > fclose(fp);
> > >
> > > mgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >>
> > VTD_CAP_MGAW_SHIFT) + 1;
> > > - if (mgaw < X86_VA_WIDTH)
> > > - return false;
> > >
> > > - return true;
> > > + if (!rte_eal_check_dma_mask(mgaw))
> > > + return true;
> > > + else
> > > + return false;
> >
> > return rte_eal_check_dma_mask(mgaw) == 0; ?
> >
> >
> > I guess that works and is more elegant.
> > Thanks.
> >
> >
> > > }
> > > #elif defined(RTE_ARCH_PPC_64)
> > > static bool
> > > @@ -615,13 +616,17 @@
> > > {
> > > struct rte_pci_device *dev = NULL;
> > > struct rte_pci_driver *drv = NULL;
> > > + int iommu_dma_mask_check_done = 0;
> > >
> > > FOREACH_DRIVER_ON_PCIBUS(drv) {
> > > FOREACH_DEVICE_ON_PCIBUS(dev) {
> > > if (!rte_pci_match(drv, dev))
> > > continue;
> > > - if (!pci_one_device_iommu_support_va(dev))
> > > - return false;
> > > + if (!iommu_dma_mask_check_done) {
> > > + if
> > (!pci_one_device_iommu_support_va(dev))
> > > + return false;
> > > + iommu_dma_mask_check_done = 1;
> > > + }
> > > }
> >
> > The commit message doesn't explain why are we only checking a single
> > device. Indeed, i am not 100% clear as to why, so some explanation in
> > the commit message and preferably a comment in code would be more
> than
> > welcome :)
> >
> >
> > Because the pci_one_device_iommu_support_va function does always the
> > same whatever the device is used in the call.
>
> So, this code was always wrong and needlessly checked each device when
> it could've checked it a single time? OK, that makes it a bit clearer.
> Still, needs to be documented in comments/commit message :) The commit
> message IMO looks quite irrelevant to what happens in the commit. It
> almost feels like this commit should be split in two - first change the
> mgaw check, and then fix the PCI bus code to not check needlessly.
>
>
Ok. Maybe that's better. I will do that in next version.
Thanks
> --
> Thanks,
> Anatoly
>
next prev parent reply other threads:[~2018-10-04 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 12:50 [dpdk-dev] [PATCH v2 0/5] use IOVAs check based on DMA mask Alejandro Lucero
2018-08-31 12:50 ` [dpdk-dev] [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses Alejandro Lucero
2018-10-03 12:43 ` Burakov, Anatoly
[not found] ` <CAD+H991m6qauwX+P=muKe6bAjNLUrcBaGbxFXkMV60OVNvRgPg@mail.gmail.com>
2018-10-04 12:59 ` [dpdk-dev] Fwd: " Alejandro Lucero
2018-10-04 15:39 ` Burakov, Anatoly
2018-10-04 17:41 ` Alejandro Lucero
2018-08-31 12:50 ` [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages Alejandro Lucero
2018-10-03 12:50 ` Burakov, Anatoly
2018-10-04 11:43 ` Alejandro Lucero
2018-10-04 12:08 ` Burakov, Anatoly
2018-10-04 13:15 ` Alejandro Lucero
2018-10-04 15:43 ` Burakov, Anatoly
2018-10-04 17:58 ` Alejandro Lucero
2018-08-31 12:50 ` [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-10-03 12:55 ` Burakov, Anatoly
2018-10-04 13:35 ` Alejandro Lucero
2018-10-04 15:49 ` Burakov, Anatoly
2018-10-04 17:59 ` Alejandro Lucero [this message]
2018-08-31 12:50 ` [dpdk-dev] [PATCH v2 4/5] net/nfp: check hugepages IOVAs based on DMA mask Alejandro Lucero
2018-08-31 12:50 ` [dpdk-dev] [PATCH v2 5/5] net/nfp: support IOVA VA mode Alejandro Lucero
2018-10-02 16:33 ` [dpdk-dev] [PATCH v2 0/5] use IOVAs check based on DMA mask Alejandro Lucero
2018-10-02 21:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+H993ni8ucU88pD1qi-kGSF3yzQAv7RiUp_i2n0vMOkPhxKQ@mail.gmail.com \
--to=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).