From: Christoph Gysin <christoph.gysin@gmail.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
Date: Tue, 13 Oct 2015 12:10:04 +0300 [thread overview]
Message-ID: <CADex797xVsuqXvfMiJPZy5g4GWbWTwo0ZzNecqiKG2sTJeJKiQ@mail.gmail.com> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478DE034@IRSMSX108.ger.corp.intel.com>
Hi David
Is there anything I can do to help getting this merged?
Thanks,
Chris
On Mon, Oct 5, 2015 at 12:44 PM, Dumitrescu, Cristian
<cristian.dumitrescu@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Christoph Gysin
>> Sent: Tuesday, September 29, 2015 7:53 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual)
>>
>> 'virtual' is a keyword and can't be used if the code is to compile with
>> C++ compilers.
>>
>> If rte_devargs.h was included in C++ code, compilation with clang++
>> failed with an error. g++ did not fail, but only because of a bug
>> that treats it as an anonymous struct with a decl-specifier which it
>> ignores.
>>
>> This simply renames the member to 'virt'.
>>
>> Signed-off-by: Christoph Gysin <christoph.gysin@gmail.com>
>> ---
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>
> Christoph, please also copy David Marchand for further updates of this patch, as David is the maintainer of this component. Whenever in doubt about the maintainer, you can check file MAINTAINERS from DPDK root folder.
>
> Regards,
> Cristian
>
--
echo mailto: NOSPAM !#$.'<*>'|sed 's. ..'|tr "<*> !#:2" org@fr33z3
next prev parent reply other threads:[~2015-10-13 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-26 13:09 Christoph Gysin
2015-09-29 6:24 ` David Marchand
2015-09-29 6:53 ` Christoph Gysin
2015-10-03 10:14 ` Christoph Gysin
2015-10-05 9:44 ` Dumitrescu, Cristian
2015-10-13 9:10 ` Christoph Gysin [this message]
2015-10-13 9:13 ` David Marchand
2015-10-13 12:23 ` David Marchand
2015-10-22 15:52 ` Thomas Monjalon
2015-09-26 13:09 Christoph Gysin
2015-09-28 20:04 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADex797xVsuqXvfMiJPZy5g4GWbWTwo0ZzNecqiKG2sTJeJKiQ@mail.gmail.com \
--to=christoph.gysin@gmail.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).