From: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] test/memzone: handle previously allocated memzones
Date: Sat, 27 Jan 2018 15:46:11 +0100 [thread overview]
Message-ID: <CAEK-wKmfrv5hp0neKnpfSp5Ki9dhE9vqTZkt+L5otGR1J=5Jtw@mail.gmail.com> (raw)
In-Reply-To: <cfcd9b2f78f4c2988d7824f69737500bd984947b.1516988093.git.anatoly.burakov@intel.com>
Thanks, looks OK for me.
Reviewed-by: Radoslaw Biernacki <r <ferruh.yigit@intel.com>
adoslaw.biernacki@linaro.com>
On 26 January 2018 at 18:40, Anatoly Burakov <anatoly.burakov@intel.com>
wrote:
> Currently, memzone autotest expects there to be no memzones
> present by the time the test is run. Some hardware drivers
> will allocate memzones for internal use during initialization,
> resulting in tests failing due to unexpected memzones being
> allocated before the test was run.
>
> Fix this by making callback increment a counter instead. This
> also doubles as a test for correct operation of memzone_walk().
>
> Fixes: 71330483a193 ("test/memzone: fix memory leak")
> Cc: radoslaw.biernacki@linaro.org
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> test/test/test_memzone.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c
> index 00d340f..5428b35 100644
> --- a/test/test/test_memzone.c
> +++ b/test/test/test_memzone.c
> @@ -953,16 +953,19 @@ test_memzone_basic(void)
> return 0;
> }
>
> -static int memzone_walk_called;
> +static int memzone_walk_cnt;
> static void memzone_walk_clb(const struct rte_memzone *mz __rte_unused,
> void *arg __rte_unused)
> {
> - memzone_walk_called = 1;
> + memzone_walk_cnt++;
> }
>
> static int
> test_memzone(void)
> {
> + /* take note of how many memzones were allocated before running */
> + int memzone_cnt = rte_eal_get_configuration()->
> mem_config->memzone_cnt;
> +
> printf("test basic memzone API\n");
> if (test_memzone_basic() < 0)
> return -1;
> @@ -1000,8 +1003,9 @@ test_memzone(void)
> return -1;
>
> printf("check memzone cleanup\n");
> + memzone_walk_cnt = 0;
> rte_memzone_walk(memzone_walk_clb, NULL);
> - if (memzone_walk_called) {
> + if (memzone_walk_cnt != memzone_cnt) {
> printf("there are some memzones left after test\n");
> rte_memzone_dump(stdout);
> return -1;
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-01-27 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eb34fe4a841eb19d62523226160b7687bb122fba.1517480079.git.anatoly.burakov@intel.com>
[not found] ` <dde08b05fd05dfa36350f73b19fb5cf9e5862ce9.1517479347.git.anatoly.burakov@intel.com>
[not found] ` <dde08b05fd05dfa36350f73b19fb5cf9e5862ce9.1517412012.git.anatoly.burakov@intel.com>
[not found] ` <ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>
2018-01-26 17:40 ` Anatoly Burakov
2018-01-27 14:46 ` Radoslaw Biernacki [this message]
2018-01-31 7:51 ` [dpdk-stable] [dpdk-dev] " Phil Yang
2018-01-31 10:05 ` Burakov, Anatoly
2018-01-31 10:08 ` Phil Yang
2018-01-31 15:29 ` [dpdk-stable] [PATCH v2 " Anatoly Burakov
2018-02-01 10:02 ` [dpdk-stable] [PATCH v3 " Anatoly Burakov
2018-02-01 10:14 ` [dpdk-stable] [PATCH v4 " Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEK-wKmfrv5hp0neKnpfSp5Ki9dhE9vqTZkt+L5otGR1J=5Jtw@mail.gmail.com' \
--to=radoslaw.biernacki@linaro.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).