From: Radoslaw Biernacki <radoslaw.biernacki@linaro.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config
Date: Sat, 27 Jan 2018 15:53:32 +0100 [thread overview]
Message-ID: <CAEK-wKn8d+vUEWbhSYRzP_4Td3L8yXH8shzbKnQWpfYn-dF-CA@mail.gmail.com> (raw)
In-Reply-To: <ec8bf2436653ce9dbbe9e83a364ca44c41bd2a8a.1516988093.git.anatoly.burakov@intel.com>
Looks OK.
Following note is aside from the patch.
Might be beneficial (in some rare cases) to add bailout recovery with
goto's in test_memzone_basic()
Just in case one of the rte_memzone_reserve() we should not make return -1,
but instead a goto to below section where we call rte_memzone_free().
This way we would be able to free only the allocated memzones and prevent
leaking out those memzones to other tests.
Reviewed-by: Radoslaw Biernacki <r <ferruh.yigit@intel.com>
adoslaw.biernacki@linaro.com>
On 26 January 2018 at 18:40, Anatoly Burakov <anatoly.burakov@intel.com>
wrote:
> Ensure that memzone count in eal mem config is incremented and
> decremented whenever memzones are allocated and freed.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> test/test/test_memzone.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c
> index f6c9b56..00d340f 100644
> --- a/test/test/test_memzone.c
> +++ b/test/test/test_memzone.c
> @@ -841,6 +841,9 @@ test_memzone_basic(void)
> const struct rte_memzone *memzone3;
> const struct rte_memzone *memzone4;
> const struct rte_memzone *mz;
> + int memzone_cnt_after, memzone_cnt_expected;
> + int memzone_cnt_before =
> + rte_eal_get_configuration()->
> mem_config->memzone_cnt;
>
> memzone1 = rte_memzone_reserve("testzone1", 100,
> SOCKET_ID_ANY, 0);
> @@ -858,6 +861,18 @@ test_memzone_basic(void)
> if (memzone1 == NULL || memzone2 == NULL || memzone4 == NULL)
> return -1;
>
> + /* check how many memzones we are expecting */
> + memzone_cnt_expected = memzone_cnt_before +
> + (memzone1 != NULL) + (memzone2 != NULL) +
> + (memzone3 != NULL) + (memzone4 != NULL);
> +
> + memzone_cnt_after =
> + rte_eal_get_configuration()->
> mem_config->memzone_cnt;
> +
> + if (memzone_cnt_after != memzone_cnt_expected)
> + return -1;
> +
> +
> rte_memzone_dump(stdout);
>
> /* check cache-line alignments */
> @@ -930,6 +945,11 @@ test_memzone_basic(void)
> return -1;
> }
>
> + memzone_cnt_after =
> + rte_eal_get_configuration()->
> mem_config->memzone_cnt;
> + if (memzone_cnt_after != memzone_cnt_before)
> + return -1;
> +
> return 0;
> }
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-01-27 14:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 17:40 Anatoly Burakov
2018-01-26 17:40 ` [dpdk-dev] [PATCH 2/2] test/memzone: handle previously allocated memzones Anatoly Burakov
2018-01-27 14:46 ` Radoslaw Biernacki
2018-01-31 7:51 ` Phil Yang
2018-01-31 10:05 ` Burakov, Anatoly
2018-01-31 10:08 ` Phil Yang
2018-01-27 14:53 ` Radoslaw Biernacki [this message]
2018-01-29 9:40 ` [dpdk-dev] [PATCH 1/2] test/memzone: add test for memzone count in eal mem config Burakov, Anatoly
2018-01-31 15:29 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
2018-02-01 0:12 ` Thomas Monjalon
2018-02-01 10:05 ` Burakov, Anatoly
2018-02-01 10:02 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2018-02-01 10:14 ` [dpdk-dev] [PATCH v4 " Anatoly Burakov
2018-02-06 0:49 ` Thomas Monjalon
2018-02-01 10:14 ` [dpdk-dev] [PATCH v4 2/2] test/memzone: handle previously allocated memzones Anatoly Burakov
2018-02-01 10:02 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2018-01-31 15:29 ` [dpdk-dev] [PATCH v2 " Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEK-wKn8d+vUEWbhSYRzP_4Td3L8yXH8shzbKnQWpfYn-dF-CA@mail.gmail.com \
--to=radoslaw.biernacki@linaro.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).