From: Igor Ryzhov <iryzhov@nfware.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Laurent Hardy <laurent.hardy@6wind.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change
Date: Thu, 11 Jan 2018 13:08:55 +0300 [thread overview]
Message-ID: <CAF+s_FwVUnvEFYkM9Pxgm+P_iTcLhF8r6hERAcB3HfZzo3daLA@mail.gmail.com> (raw)
In-Reply-To: <94479800C636CB44BD422CB454846E013208AD5B@SHSMSX101.ccr.corp.intel.com>
Sent v2: https://dpdk.org/dev/patchwork/patch/33570/
On Thu, Jan 11, 2018 at 11:21 AM, Xing, Beilei <beilei.xing@intel.com>
wrote:
> Hi Igor,
>
>
>
> Thanks for the catch, and glad to see your patchJ It resolves a potential
> problem in PMD.
>
> The patch looks OK for me except some minor comments (in another mail
> thread).
>
>
>
> Best Regards,
>
> Beilei
>
>
>
> *From:* Igor Ryzhov [mailto:iryzhov@nfware.com]
> *Sent:* Thursday, January 11, 2018 6:47 AM
> *To:* Zhang, Helin <helin.zhang@intel.com>
> *Cc:* Xing, Beilei <beilei.xing@intel.com>; Olivier Matz <
> olivier.matz@6wind.com>; dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>;
> stable@dpdk.org; Laurent Hardy <laurent.hardy@6wind.com>
>
> *Subject:* Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary
> address change
>
>
>
> Hello everyone.
>
>
>
> It's sad that my comments were unanswered.
>
> I'm ok with the first two – they were mostly style-related.
>
> But I made an investigation on the third one and it is a bug.
>
>
>
> This is a description (from X710 datasheet) of flags sent to
> mac_address_write command:
>
>
>
> By bits:
>
> 0-7 – Reserved
>
> 8 – MAC_MAG_EN
>
> 9 – LAA_WOL_PRESERVE
>
> 10-13 – Reserved
>
> 14-15 – Write type (00 – Update LAA only, 01 – Update LAA and WOL, 10 –
> Update port address, 11 – Reserved, but used in Linux to enable multicast
> magic packet wake up)
>
>
>
> Current code uses 0x3 flag, apparently trying to update LAA, WOL and port
> address, but it sets first two bits instead of last two.
>
> These bits are reserved, that's why it doesn't break anything.
>
> At the same time, last two bits are set to zero, and the command changes
> LAA address only – it's enough to work in simple case.
>
>
>
> The last question – which flag is correct to use – 01 (LAA + WOL) or 11
> (LAA + WOL + port).
>
> Linux driver uses the first one, and here is the patch to fix the issue:
>
> https://dpdk.org/dev/patchwork/patch/33524/
>
>
>
> Best regards,
>
> Igor
>
>
>
> On Wed, Jan 10, 2018 at 4:57 PM, Zhang, Helin <helin.zhang@intel.com>
> wrote:
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xing, Beilei
> > Sent: Thursday, January 4, 2018 1:39 PM
> > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing
> > Cc: stable@dpdk.org; Laurent Hardy
> > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary
> address
> > change
> >
> >
> >
> > > -----Original Message-----
> > > From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > > Sent: Wednesday, January 3, 2018 10:29 PM
> > > To: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > > <beilei.xing@intel.com>
> > > Cc: stable@dpdk.org; Laurent Hardy <laurent.hardy@6wind.com>
> > > Subject: [PATCH] net/i40e: fix VSI MAC filter on primary address
> > > change
> > >
> > > When primary address mac is changed, the mac filters were not updated
> > > in the VSI with the new mac addr and incoming packets with this
> > > destination address are dropped by the hardware filters.
> > >
> > > This patch removes the VSI mac filter for the previous mac address and
> > > adds a new one for new mac address.
> > >
> > > Fixes: e18e01e92c29 ("i40e: support default MAC address setting")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
> > > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> >
> > Thanks for the fix.
> > Acked-by: Beilei Xing <beilei.xing@intel.com>
>
> Applied to dpdk-next-net-intel, thanks!
>
> /Helin
>
>
>
next prev parent reply other threads:[~2018-01-11 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 14:29 [dpdk-stable] " Olivier Matz
2018-01-04 5:39 ` Xing, Beilei
2018-01-10 13:57 ` [dpdk-stable] [dpdk-dev] " Zhang, Helin
2018-01-10 22:46 ` Igor Ryzhov
2018-01-11 8:21 ` Xing, Beilei
2018-01-11 10:08 ` Igor Ryzhov [this message]
2018-01-05 12:34 ` Igor Ryzhov
2018-01-08 6:36 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_FwVUnvEFYkM9Pxgm+P_iTcLhF8r6hERAcB3HfZzo3daLA@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=laurent.hardy@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).