From: Igor Ryzhov <iryzhov@nfware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats
Date: Wed, 14 Oct 2020 12:35:34 +0300 [thread overview]
Message-ID: <CAF+s_FxXux9ntb3AS3RBM0Si7WqcDYLEmyFwx4+eXLuoT_S_fw@mail.gmail.com> (raw)
In-Reply-To: <20201014022649.2165524-2-ferruh.yigit@intel.com>
Hi Ferruh,
As rte_eth_stats is going to be changed, is it possible to add new counters
there?
For example, in/out multicast/broadcast packets.
Igor
On Wed, Oct 14, 2020 at 5:27 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Queue stats will be removed from basic stats to xstats.
>
> It will be PMDs responsibility to fill queue stats based on number of
> queues they have.
>
> Until all PMDs implement the xstats, a temporary
> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' device flag created. PMDs switched
> to the xstats should clear this flag to bypass the ethdev layer autofill
> for queue stats.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> config/rte_config.h | 2 +-
> doc/guides/rel_notes/deprecation.rst | 7 +++++++
> lib/librte_ethdev/rte_ethdev.h | 3 +++
> 3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 03d90d78bc..9ef3b75940 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -55,7 +55,7 @@
>
> /* ether defines */
> #define RTE_MAX_QUEUES_PER_PORT 1024
> -#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16
> +#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 /* max 256 */
> #define RTE_ETHDEV_RXTX_CALLBACKS 1
>
> /* cryptodev defines */
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 584e720879..9143cfc529 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -164,6 +164,13 @@ Deprecation Notices
> following the IPv6 header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177257.html.
>
> +* ethdev: Queue specific stats fields will be removed from ``struct
> rte_eth_stats``.
> + Mentioned fields are: ``q_ipackets``, ``q_opackets``, ``q_ibytes``,
> ``q_obytes``,
> + ``q_errors``.
> + Instead queue stats will be received via xstats API. Current method
> support
> + will be limited to maximum 256 queues.
> + Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.
> +
> * security: The API ``rte_security_session_create`` takes only single
> mempool
> for session and session private data. So the application need to create
> mempool for twice the number of sessions needed and will also lead to
> diff --git a/lib/librte_ethdev/rte_ethdev.h
> b/lib/librte_ethdev/rte_ethdev.h
> index bb7a2b4289..a2e811ca48 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -253,6 +253,7 @@ struct rte_eth_stats {
> uint64_t ierrors; /**< Total number of erroneous received
> packets. */
> uint64_t oerrors; /**< Total number of failed transmitted
> packets. */
> uint64_t rx_nombuf; /**< Total number of RX mbuf allocation
> failures. */
> + /* Queue stats are limited to max 256 queues */
> uint64_t q_ipackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];
> /**< Total number of queue RX packets. */
> uint64_t q_opackets[RTE_ETHDEV_QUEUE_STAT_CNTRS];
> @@ -2704,6 +2705,7 @@ int rte_eth_xstats_reset(uint16_t port_id);
> * The per-queue packet statistics functionality number that the
> transmit
> * queue is to be assigned.
> * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1].
> + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256.
> * @return
> * Zero if successful. Non-zero otherwise.
> */
> @@ -2724,6 +2726,7 @@ int rte_eth_dev_set_tx_queue_stats_mapping(uint16_t
> port_id,
> * The per-queue packet statistics functionality number that the receive
> * queue is to be assigned.
> * The value must be in the range [0, RTE_ETHDEV_QUEUE_STAT_CNTRS - 1].
> + * Max RTE_ETHDEV_QUEUE_STAT_CNTRS being 256.
> * @return
> * Zero if successful. Non-zero otherwise.
> */
> --
> 2.26.2
>
>
next prev parent reply other threads:[~2020-10-14 9:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:46 [dpdk-dev] [RFC 1/2] ethdev: move queue stats " Ferruh Yigit
2020-10-12 16:46 ` [dpdk-dev] [RFC 2/2] doc: announce queue stats moving " Ferruh Yigit
2020-10-12 16:55 ` [dpdk-dev] [dpdk-techboard] " Stephen Hemminger
2020-10-12 21:53 ` [dpdk-dev] [RFC 1/2] ethdev: move queue stats " Thomas Monjalon
2020-10-13 8:31 ` Andrew Rybchenko
2020-10-13 9:05 ` Thomas Monjalon
2020-10-13 9:16 ` Andrew Rybchenko
2020-10-13 22:41 ` Ferruh Yigit
2020-10-13 15:04 ` Stephen Hemminger
2020-10-13 22:53 ` Ferruh Yigit
2020-10-14 2:26 ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Ferruh Yigit
2020-10-14 2:26 ` [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats Ferruh Yigit
2020-10-14 8:43 ` Kinsella, Ray
2020-10-16 14:34 ` Thomas Monjalon
2020-10-16 14:36 ` Bruce Richardson
2020-10-16 14:37 ` Jerin Jacob
2020-10-16 15:07 ` Stephen Hemminger
2020-10-16 17:48 ` Ajit Khaparde
2020-10-14 9:35 ` Igor Ryzhov [this message]
2020-10-14 9:45 ` Thomas Monjalon
2020-10-15 7:55 ` Igor Ryzhov
2020-10-15 8:03 ` Thomas Monjalon
2020-10-15 17:39 ` Igor Ryzhov
2020-10-15 17:45 ` Thomas Monjalon
2020-10-14 8:40 ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Wang, Haiyue
2020-10-14 8:46 ` Wang, Xiao W
2020-10-16 12:16 ` Ferruh Yigit
2020-10-16 14:32 ` Thomas Monjalon
2020-10-16 21:38 ` Ferruh Yigit
2020-10-19 3:03 ` Min Hu (Connor)
2020-10-18 12:09 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_FxXux9ntb3AS3RBM0Si7WqcDYLEmyFwx4+eXLuoT_S_fw@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).