From: Masaru Oki <m-oki@stratosphere.co.jp>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: "<dev@dpdk.org>" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety
Date: Thu, 23 Oct 2014 08:43:39 +0900 [thread overview]
Message-ID: <CAFLKUzKY5488C-e5LwVd=+JqxgoLOv8ddURtPYVgntevrY6aEQ@mail.gmail.com> (raw)
In-Reply-To: <1413975345-24326-2-git-send-email-bruce.richardson@intel.com>
Hi,
in this code, pointer of local variable (mb_def) is returned by your changes.
mb_def should be static for each thread.
2014-10-22 19:55 GMT+09:00 Bruce Richardson <bruce.richardson@intel.com>:
> Remove the "static" prefix to the template mbuf variable in
> ixgbe_rxq_vec_setup function. This will then allow different
> threads to initialize different RX queues at the same time,
> without one overwriting the other's data.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> index a0d3d78..e813e43 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c
> @@ -730,7 +730,7 @@ static struct ixgbe_txq_ops vec_txq_ops = {
> int
> ixgbe_rxq_vec_setup(struct igb_rx_queue *rxq)
> {
> - static struct rte_mbuf mb_def = {
> + struct rte_mbuf mb_def = {
> .nb_segs = 1,
> .data_off = RTE_PKTMBUF_HEADROOM,
> #ifdef RTE_MBUF_REFCNT
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-10-22 23:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 10:55 [dpdk-dev] [PATCH 0/2] ixgbe: vector pmd fixes Bruce Richardson
2014-10-22 10:55 ` [dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety Bruce Richardson
2014-10-22 23:43 ` Masaru Oki [this message]
2014-10-24 10:34 ` Bruce Richardson
2014-10-24 11:00 ` Masaru Oki
2014-10-22 10:55 ` [dpdk-dev] [PATCH 2/2] ixgbe: always perform vec RX setup if vpmd enabled Bruce Richardson
2014-10-23 1:40 ` [dpdk-dev] [PATCH 0/2] ixgbe: vector pmd fixes Ouyang, Changchun
2014-10-29 23:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLKUzKY5488C-e5LwVd=+JqxgoLOv8ddURtPYVgntevrY6aEQ@mail.gmail.com' \
--to=m-oki@stratosphere.co.jp \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).