From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c
Date: Tue, 14 Apr 2015 14:35:04 -0700 [thread overview]
Message-ID: <CAFb4SLBUrSviEu3+f-vv3j4OktjodM5Dy0AUbxrpa2QtxpAVWQ@mail.gmail.com> (raw)
In-Reply-To: <1653003.yPkaDFgZKF@xps13>
On Tue, Apr 14, 2015 at 6:59 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> Hi Ravi,
>
> 2015-04-09 12:40, Ravi Kerur:
> > --- a/lib/librte_eal/common/eal_common_thread.c
> > +++ b/lib/librte_eal/common/eal_common_thread.c
> [...]
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > +#include <pthread_np.h>
> > +#include <sys/thr.h>
> > +#else /* RTE_EXEC_ENV_BSDAPP */
> > #include <pthread.h>
> > +#endif /* RTE_EXEC_ENV_BSDAPP */
> [...]
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > + RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%p;cpuset=[%s%s])\n",
> > + lcore_id, thread_id, cpuset, ret == 0 ? "" : "...");
> > +#else /* RTE_EXEC_ENV_BSDAPP */
> > + RTE_LOG(DEBUG, EAL, "lcore %u is ready (tid=%x;cpuset=[%s%s])\n",
> > + lcore_id, (int)thread_id, cpuset, ret == 0 ? "" : "...");
> > +#endif /* RTE_EXEC_ENV_BSDAPP */
>
> These lines should stay in bsdapp and linuxapp directory.
> You can add a new function to eal_thread.h to format the thread id,
> so you'll be able to use %s in generic log above.
>
Thomas, sure will make the changes. I will wait for additional comments if
any for other patches and send v6 together.
Thanks.
next prev parent reply other threads:[~2015-04-14 21:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:38 [dpdk-dev] [PATCH v5 0/8] Move common functions in EAL Ravi Kerur
2015-04-09 19:40 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c Ravi Kerur
2015-04-14 13:59 ` Thomas Monjalon
2015-04-14 21:35 ` Ravi Kerur [this message]
2015-04-16 22:19 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c Ravi Kerur
2015-04-16 8:24 ` Thomas Monjalon
2015-04-16 22:08 ` Ravi Kerur
2015-04-16 22:22 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 3/8] Move common functions in eal_lcore.c Ravi Kerur
2015-04-16 8:39 ` Thomas Monjalon
2015-04-16 22:10 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c Ravi Kerur
2015-04-16 8:46 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c Ravi Kerur
2015-04-16 8:52 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c Ravi Kerur
2015-04-16 9:02 ` Thomas Monjalon
2015-04-16 22:12 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFb4SLBUrSviEu3+f-vv3j4OktjodM5Dy0AUbxrpa2QtxpAVWQ@mail.gmail.com \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).