From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c
Date: Thu, 16 Apr 2015 15:11:47 -0700 [thread overview]
Message-ID: <CAFb4SLC-SPgA6P_9iXD1TMch0S9+_q-Qd=EKwuUyT3JMQg4XSw@mail.gmail.com> (raw)
In-Reply-To: <119098819.UXtPphdbAd@xps13>
On Thu, Apr 16, 2015 at 1:52 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2015-04-09 12:40, Ravi Kerur:
> > Changes in v5
> > Rebase to latest code.
> >
> > Changes in v4
> > Make rte_eal_hugepage_init and rte_eal_hugepage_attach as
> > wrapper functions for BSD.
> >
> > Changes in v3
> > Changed subject to be more explicit on file name inclusion.
> >
> > Changes in v2
> > Use common function names rte_eal_hugepage_init and
> > rte_eal_hugepage_attach for BSD and Linux. Update comments about its
> > actuality in function declaration.
> >
> > Changes in v1
> > Move common functions in eal_memory.c to librte_eal/common/
> > eal_common_memory.c file.
> >
> > Following functions are moved to eal_common_memory.c file
> >
> > static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void);
> >
> > Fix checkpatch warnings and errors.
> >
> > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> [...]
> > +/**
> > + * This function prepares physical memory mapping
> > + * i.e. hugepages on Linux and
> > + * contigmem on BSD.
>
> OK
>
> > + * It is a wrapper function for BSD which will
> > + * internally call contigmem_init.
>
> Please avoid such comment which is difficult to maintain and not really
> useful.
>
> > + * It is a wrapper function for BSD which will
> > + * internally call contigmem_attach.
>
> Same comment.
>
> Except the above comments, it seems goods.
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Thanks
>
Will fix comments in next version.
next prev parent reply other threads:[~2015-04-16 22:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:38 [dpdk-dev] [PATCH v5 0/8] Move common functions in EAL Ravi Kerur
2015-04-09 19:40 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c Ravi Kerur
2015-04-14 13:59 ` Thomas Monjalon
2015-04-14 21:35 ` Ravi Kerur
2015-04-16 22:19 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c Ravi Kerur
2015-04-16 8:24 ` Thomas Monjalon
2015-04-16 22:08 ` Ravi Kerur
2015-04-16 22:22 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 3/8] Move common functions in eal_lcore.c Ravi Kerur
2015-04-16 8:39 ` Thomas Monjalon
2015-04-16 22:10 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c Ravi Kerur
2015-04-16 8:46 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c Ravi Kerur
2015-04-16 8:52 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur [this message]
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c Ravi Kerur
2015-04-16 9:02 ` Thomas Monjalon
2015-04-16 22:12 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFb4SLC-SPgA6P_9iXD1TMch0S9+_q-Qd=EKwuUyT3JMQg4XSw@mail.gmail.com' \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).