From: Ravi Kerur <rkerur@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c
Date: Thu, 16 Apr 2015 15:11:04 -0700 [thread overview]
Message-ID: <CAFb4SLDAuRzmbv9QPM7MEq_GHF6XNyauRit3q7C8Akny2M1G4g@mail.gmail.com> (raw)
In-Reply-To: <2134052.2sEotUrNoM@xps13>
On Thu, Apr 16, 2015 at 1:46 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2015-04-09 12:40, Ravi Kerur:
> > Changes in v5
> > Rebase to latest code.
> >
> > Changes in v4
> > Removed extern declaration of eal_tsc_resolution_hz,
> > instead provided _set_ API.
> > Make set_tsc_freq_from_clock as wrapper function for BSD.
> >
> > Changes in v3
> > Changed subject to be more explicit on file name inclusion.
> >
> > Changes in v2
> > Use common function name set_tsc_freq_from_sysctl for BSD and Linux.
> > Update comments about its actuality in function declaration.
> >
> > Changes in v1
> > Move common functions in eal_timer.c to librte_eal/common/
> > eal_common_timer.c file.
> >
> > Following functions are moved to eal_common_timer.c file
> >
> > void rte_delay_us(unsigned us);
> > uint64_t rte_get_tsc_hz(void);
> > static void set_tsc_freq_fallback(void);
> > void set_tsc_freq(void);
> >
> > Makefile changes to reflect new file added.
> > Fix checkpatch warnings and errors.
> >
> > Signed-off-by: Ravi Kerur <rkerur@gmail.com>
>
> Seems good.
> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> Minor nit, a blank line is missing:
>
Will fix this in next version.
> > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
> DAMAGE.
> > + */
> > +#include <string.h>
>
next prev parent reply other threads:[~2015-04-16 22:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:38 [dpdk-dev] [PATCH v5 0/8] Move common functions in EAL Ravi Kerur
2015-04-09 19:40 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 1/8] Move common functions in eal_thread.c Ravi Kerur
2015-04-14 13:59 ` Thomas Monjalon
2015-04-14 21:35 ` Ravi Kerur
2015-04-16 22:19 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 2/8] Move common functions in eal.c Ravi Kerur
2015-04-16 8:24 ` Thomas Monjalon
2015-04-16 22:08 ` Ravi Kerur
2015-04-16 22:22 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 3/8] Move common functions in eal_lcore.c Ravi Kerur
2015-04-16 8:39 ` Thomas Monjalon
2015-04-16 22:10 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c Ravi Kerur
2015-04-16 8:46 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur [this message]
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 5/8] Move common functions in eal_memory.c Ravi Kerur
2015-04-16 8:52 ` Thomas Monjalon
2015-04-16 22:11 ` Ravi Kerur
2015-04-09 19:40 ` [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c Ravi Kerur
2015-04-16 9:02 ` Thomas Monjalon
2015-04-16 22:12 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFb4SLDAuRzmbv9QPM7MEq_GHF6XNyauRit3q7C8Akny2M1G4g@mail.gmail.com \
--to=rkerur@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).