From: Ravi Kerur <rkerur@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [v3 2/3] LPM config file read option.
Date: Mon, 6 Mar 2017 15:16:42 -0800 [thread overview]
Message-ID: <CAFb4SLDNf03Q6v7rAubVJdJRkrNbNW=KjPQHXw9Czqz-22J9rw@mail.gmail.com> (raw)
In-Reply-To: <20170306084620.5bb094b5@xeon-e3>
Sure Stephen will make the changes.
On Mon, Mar 6, 2017 at 8:46 AM, Stephen Hemminger <
stephen@networkplumber.org> wrote:
> On Sat, 4 Mar 2017 12:44:18 -0800
> Ravi Kerur <rkerur@gmail.com> wrote:
>
> > +/* Bypass comment and empty lines */
> > +static inline int
> > +is_bypass_line(char *buff)
> > +{
> > + int i = 0;
> > +
> > + /* comment line */
> > + if (buff[0] == COMMENT_LEAD_CHAR)
> > + return 1;
> > + /* empty line */
> > + while (buff[i] != '\0') {
> > + if (!isspace(buff[i]))
> > + return 0;
> > + i++;
> > + }
> > + return 1;
> > +}
>
> This is not performance crtitical should not be inline.
> The argument is never modified and therefore should be "const char *buff"
>
next prev parent reply other threads:[~2017-03-06 23:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 20:44 [dpdk-dev] [v3 0/3] Merge l3fwd-acl and l3fwd Ravi Kerur
2017-03-04 20:44 ` [dpdk-dev] [v3 1/3] Merge l3fwd-acl and l3fwd code Ravi Kerur
2017-03-04 20:44 ` [dpdk-dev] [v3 2/3] LPM config file read option Ravi Kerur
2017-03-06 16:45 ` Stephen Hemminger
2017-03-06 16:46 ` Stephen Hemminger
2017-03-06 23:16 ` Ravi Kerur [this message]
2017-03-04 20:44 ` [dpdk-dev] [v3 3/3] EM " Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFb4SLDNf03Q6v7rAubVJdJRkrNbNW=KjPQHXw9Czqz-22J9rw@mail.gmail.com' \
--to=rkerur@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).