From: Ravi Kerur <rkerur@gmail.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [RFC 17.05 v1 0/3] Merge l3fwd-acl and l3fwd
Date: Sun, 5 Mar 2017 11:55:09 -0800 [thread overview]
Message-ID: <CAFb4SLDNpyusROYAofnfiavKHhPwd1PTOsW79zOyYJAqRUcP8A@mail.gmail.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAC9B8B@IRSMSX109.ger.corp.intel.com>
Hi Konstantin,
Thanks for the inputs.
Initialization starts with ETH_RSS_IP and gets updated with L4 if ACL is
selected in parse_args function. This change is to fix rss_hf.
I have submitted 'v4' patch, please let me know if additional changes are
needed.
Thanks.
On Sun, Mar 5, 2017 at 5:15 AM, Ananyev, Konstantin <
konstantin.ananyev@intel.com> wrote:
>
> Hi Ravi,
>
> >
> > Hi Konstantin,
> >
> > Sorry for this one, I had to resend patch series as 'v3' as additional
> checkpatch warnings were seen after the submission which didn't show
> > up in my run.
> >
> > 'v3' patch should have all fixed except the ones I mentioned in my
> earlier email on which I need inputs from you.
> >
> > Thanks.
> >
> > On Sat, Mar 4, 2017 at 11:49 AM, Ravi Kerur <rkerur@gmail.com> wrote:
> > Hi Konstantin,
> >
> > I have sent 'v2' patchset. I need clarifications on following things, if
> they should be fixed I will send out 'v3' so please let me know.
> >
> > Following code changes were done by me manually, not merged.
> > +++ b/examples/l3fwd/main.c
> > @@ -161,7 +163,9 @@ static struct rte_eth_conf port_conf = {
> > .rx_adv_conf = {
> > .rss_conf = {
> > .rss_key = NULL,
> > - .rss_hf = ETH_RSS_IP,
> > + .rss_hf = ETH_RSS_IP | ETH_RSS_UDP |
> > + ETH_RSS_TCP | ETH_RSS_SCTP,
> > +
> > },
> >
> > The reason I did it is because
> >
> > LPM/EM has .rss_hf = ETH_RSS_IP
> > ACL has .rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP | ETH_RSS_SCTP,
> >
> > ACL looks like a superset of LPM/EM and functional testing didn't reveal
> any issues hence I kept ACL version.
>
> But at least for LPM, we probably don't want L4 ports affect packet
> distribution?
> Probably the safest way would be to have a separate port_conf for each
> case (LPM/EM/ACL).
> That way will preserve the original behavior.
>
> >
> > 2. Checkpatch errors are all fixed. Some warnings are not fixed and they
> are
> >
> > 2.a, string length greater than 80 characters
> > 2.b GET_CB_FIELD macro. I could have changed GET_CB_FIELD to inline
> function, however, function names cannot be in capital letters. I
> > could have changed it to 'get_cb_field' inline function, but didn't do
> it as I thought it may not be worth the change.
>
> It is ok by me to leave as it is by now.
> Thanks
> Konstantin
>
>
>
>
next prev parent reply other threads:[~2017-03-05 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-05 13:15 Ananyev, Konstantin
2017-03-05 19:55 ` Ravi Kerur [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-27 20:59 Ravi Kerur
2017-02-28 10:36 ` Ananyev, Konstantin
2017-03-01 15:29 ` Ravi Kerur
2017-03-04 19:49 ` Ravi Kerur
2017-03-04 20:47 ` Ravi Kerur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFb4SLDNpyusROYAofnfiavKHhPwd1PTOsW79zOyYJAqRUcP8A@mail.gmail.com \
--to=rkerur@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).