From: Alex Wang <alex@awakenetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Alex Wang <ee07b291@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2 v2] kni: Add documentation for the mempool capacity
Date: Mon, 23 May 2016 10:12:33 -0700 [thread overview]
Message-ID: <CAFg=G3PMDLXWQqqkA3Orn0ct=9K2y8dKzbEvGO-dYmN2iWBxrQ@mail.gmail.com> (raw)
In-Reply-To: <5743398C.1090504@intel.com>
Shoooot, sorry for missing that, sending V3,
On Mon, May 23, 2016 at 10:10 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 5/23/2016 6:00 PM, Ferruh Yigit wrote:
> > On 5/21/2016 8:25 AM, Alex Wang wrote:
> >> From: Alex Wang <alex@awakenetworks.com>
> >>
> >> Function like 'rte_kni_rx_burst()' keeps
> >> allocating 'MAX_MBUF_BURST_NUM' mbufs to
> >> kni fifo queue unless the queue's capacity
> >> ('KNI_FIFO_COUNT_MAX') is reached. So, if
> >> the mempool is under-provisioned, user may
> >> run into "Out of Memory" logs from KNI code.
> >> This commit documents the need to provision
> >> mempool capacity of more than
> >> "2 x KNI_FIFO_COUNT_MAX" for each KNI interface.
> >>
> >> Signed-off-by: Alex Wang <alex@awakenetworks.com>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
>
> Hi Alex,
>
> This is detail but I just recognized patch subject after tag starts with
> uppercase. Would you mind sending another patch? You can keep my ack
> with it.
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2016-05-23 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 7:25 [dpdk-dev] [PATCH 1/2 v2] kni: fix inverted function comments Alex Wang
2016-05-21 7:25 ` [dpdk-dev] [PATCH 2/2 v2] kni: Add documentation for the mempool capacity Alex Wang
2016-05-23 17:00 ` Ferruh Yigit
2016-05-23 17:10 ` Ferruh Yigit
2016-05-23 17:12 ` Alex Wang [this message]
2016-05-23 17:00 ` [dpdk-dev] [PATCH 1/2 v2] kni: fix inverted function comments Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFg=G3PMDLXWQqqkA3Orn0ct=9K2y8dKzbEvGO-dYmN2iWBxrQ@mail.gmail.com' \
--to=alex@awakenetworks.com \
--cc=dev@dpdk.org \
--cc=ee07b291@gmail.com \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).