From: Chas Williams <3chas3@gmail.com>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
Thomas Monjalon <thomas@monjalon.net>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bonding: fix invalid port id error
Date: Thu, 19 Jul 2018 13:45:20 -0400 [thread overview]
Message-ID: <CAG2-GkmZQsjcqaQb4PW6ndwmU6a_nk-SON5LRXXPMozeB8Qu0g@mail.gmail.com> (raw)
In-Reply-To: <1531912321-19544-1-git-send-email-radu.nicolau@intel.com>
This seems fine. The bond PMD seems to call back into itself early.
On Wed, Jul 18, 2018 at 7:19 AM Radu Nicolau <radu.nicolau@intel.com> wrote:
> setting up the bonding options before calling rte_eth_dev_probing_finish
> triggers an invalid port id error because of port state not set, or set
> unused
>
> Fixes: fbe90cdd776c ("ethdev: add probing finish function")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>
Signed-off-by: Chas Williams <chas3@att.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c
> b/drivers/net/bonding/rte_eth_bond_pmd.c
> index fc4d4fd..1320cfd 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3238,6 +3238,7 @@ bond_probe(struct rte_vdev_device *dev)
> internals = rte_eth_devices[port_id].data->dev_private;
> internals->kvlist = kvlist;
>
> + rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
>
> if (rte_kvargs_count(kvlist, PMD_BOND_AGG_MODE_KVARG) == 1) {
> if (rte_kvargs_process(kvlist,
> @@ -3257,7 +3258,6 @@ bond_probe(struct rte_vdev_device *dev)
> rte_eth_bond_8023ad_agg_selection_set(port_id, AGG_STABLE);
> }
>
> - rte_eth_dev_probing_finish(&rte_eth_devices[port_id]);
> RTE_BOND_LOG(INFO, "Create bonded device %s on port %d in mode %u
> on "
> "socket %u.", name, port_id, bonding_mode,
> socket_id);
> return 0;
> --
> 2.7.5
>
>
next prev parent reply other threads:[~2018-07-19 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 11:12 [dpdk-stable] " Radu Nicolau
2018-07-19 17:45 ` Chas Williams [this message]
2018-07-20 15:12 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG2-GkmZQsjcqaQb4PW6ndwmU6a_nk-SON5LRXXPMozeB8Qu0g@mail.gmail.com \
--to=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).