From: Matteo Croce <mcroce@redhat.com>
To: Kyle Larose <klarose@sandvine.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: remove warning
Date: Thu, 14 Dec 2017 21:18:31 +0100 [thread overview]
Message-ID: <CAGnkfhyRuYvt2J=ULmPE3m7rmEcqdA7kPmJh+AO5N4O46-_Crg@mail.gmail.com> (raw)
In-Reply-To: <2d7fb769e8d846c69fe3f5b39ed8fa36@sandvine.com>
On Thu, Dec 14, 2017 at 9:15 PM, Kyle Larose <klarose@sandvine.com> wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matteo Croce
>> Sent: Thursday, December 14, 2017 1:23 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] i40e: remove warning
>>
>> Fix a printf warning which made the compilation fail when compiling with GCC
>> 7.2 and -Werror:
>>
>> error: format ‘%llu’ expects argument of type ‘long long unsigned int’,
>> but argument 8 has type ‘u64 {aka long unsigned int}’ [-Werror=format=]
>>
>> Signed-off-by: Matteo Croce <mcroce@redhat.com>
>> ---
>> drivers/net/i40e/base/i40e_common.c | 2 +-
>> drivers/net/i40e/base/i40e_nvm.c | 6 +++---
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/i40e/base/i40e_common.c
>> b/drivers/net/i40e/base/i40e_common.c
>> index 900d379ca..14834e8f2 100644
>> --- a/drivers/net/i40e/base/i40e_common.c
>> +++ b/drivers/net/i40e/base/i40e_common.c
>> @@ -3929,7 +3929,7 @@ STATIC void i40e_parse_discover_capabilities(struct
>> i40e_hw *hw, void *buff,
>> p->wr_csr_prot = (u64)number;
>> p->wr_csr_prot |= (u64)logical_id << 32;
>> i40e_debug(hw, I40E_DEBUG_INIT,
>> - "HW Capability: wr_csr_prot = 0x%llX\n\n",
>> + "HW Capability: wr_csr_prot = 0x%lX\n\n",
>> (p->wr_csr_prot & 0xffff));
>> break;
>> case I40E_AQ_CAP_ID_NVM_MGMT:
>
>
> wr_src_prot is a u64, which will translate to long long on 32-bit systems. This will likely trip over a similar warning in that case.
> Should we instead use "HW Capability: wr_src_prot = 0x"PRIX64"\n\n"?
>
> See inttypes.h for more info.
>
Indeed. I'm making a v2 anyway because there are non printable color
codes from the GCC output
--
Matteo Croce
per aspera ad upstream
next prev parent reply other threads:[~2017-12-14 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 18:22 Matteo Croce
2017-12-14 20:15 ` Kyle Larose
2017-12-14 20:18 ` Matteo Croce [this message]
2017-12-14 20:40 ` [dpdk-dev] [PATCH v2] " Matteo Croce
2017-12-14 22:26 ` Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGnkfhyRuYvt2J=ULmPE3m7rmEcqdA7kPmJh+AO5N4O46-_Crg@mail.gmail.com' \
--to=mcroce@redhat.com \
--cc=dev@dpdk.org \
--cc=klarose@sandvine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).